Remove maxfps, graphic update and all update methods in the UI classes and just redraw the screen at 60 fps
Bug #1395630 reported by
SirVer
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
This is a rendering improvement made possible through the removal of the software renderer.
The UI especially tries to keep track of which parts of the screen are 'dirty' and need redrawing. There is also the g_gr->update() method that will force redraw the screen.
With OpenGL these concepts are not useful - redrawing the screen is very cheap, usually cheaper than redrawing only parts of it. We can remove these and just redraw the screen at 60 frames per second. This means also getting rid of maxfps.
Related branches
lp:~widelands-dev/widelands/remove_update
- GunChleoc: Approve (testing)
-
Diff: 1233 lines (+20/-280)34 files modifiedsrc/editor/ui_menus/editor_tool_menu.cc (+0/-1)
src/graphic/graphic.cc (+0/-19)
src/graphic/graphic.h (+0/-5)
src/logic/map_objects/tribes/production_program.cc (+1/-1)
src/ui_basic/button.cc (+1/-11)
src/ui_basic/checkbox.cc (+0/-7)
src/ui_basic/editbox.cc (+0/-13)
src/ui_basic/icon.cc (+0/-1)
src/ui_basic/listselect.cc (+0/-7)
src/ui_basic/multilineeditbox.cc (+0/-8)
src/ui_basic/multilinetextarea.cc (+0/-6)
src/ui_basic/panel.cc (+13/-102)
src/ui_basic/panel.h (+0/-3)
src/ui_basic/progressbar.cc (+0/-4)
src/ui_basic/progresswindow.cc (+1/-3)
src/ui_basic/scrollbar.cc (+0/-5)
src/ui_basic/slider.cc (+1/-17)
src/ui_basic/table.cc (+0/-8)
src/ui_basic/tabpanel.cc (+0/-7)
src/ui_basic/textarea.cc (+0/-2)
src/ui_basic/window.cc (+0/-1)
src/wui/game_message_menu.cc (+0/-3)
src/wui/game_summary.cc (+0/-1)
src/wui/game_tips.cc (+0/-2)
src/wui/interactive_base.cc (+0/-5)
src/wui/itemwaresdisplay.cc (+1/-5)
src/wui/mapview.cc (+0/-2)
src/wui/minimap.cc (+0/-2)
src/wui/productionsitewindow.cc (+0/-1)
src/wui/soldierlist.cc (+0/-1)
src/wui/waresdisplay.cc (+0/-14)
src/wui/waresdisplay.h (+0/-3)
src/wui/waresqueuedisplay.cc (+2/-9)
src/wui/waresqueuedisplay.h (+0/-1)
| tags: | added: opengl |
| Changed in widelands: | |
| importance: | Undecided → Medium |
| assignee: | nobody → SirVer (sirver) |
| milestone: | none → build19-rc1 |
Revision history for this message
| SirVer (sirver) wrote | #1 |
| Changed in widelands: | |
| status: | Confirmed → In Progress |
Revision history for this message
| SirVer (sirver) wrote | #2 |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
| assignee: | SirVer (sirver) → nobody |
| tags: |
added: graphics removed: graphic |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #3 |
To post a comment you must log in.
Our rendering is not performant enough to redraw everything at 60fps all the time, but the update() can now be removed. See attached branch.