Editor: Second alternative tool needs different access key

Bug #1395322 reported by GunChleoc
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Low
Unassigned

Bug Description

In Ubuntu, Alt is grabbed by the window manager, so the second alternative tool in the editor can't be accessed. So, we need a different access key here. Maybe ALT GR or MODE would do the trick?

Tags: editor ui

Related branches

Revision history for this message
Hans Joachim Desserud (hjd) wrote :

I have to admit I haven't used the editor much, so I don't know much about this feature, but it was never clear to me what alt+click was supposed to do. (Plus I'm also running Ubuntu, so apart from moving the window about experimenting with it didn't yield much.)

Clicking places things, shift+click usually removes it again so those two are straight-forward. The editor tips includes this little hint: "Holding down ALT switches the second alternative tool on (if it exists)." So presumably, it is not available for all types/tools. Which type(s) is available for, and is it the same functionality offered for all these?

I think it will be easier to discuss this if we have a clear idea of what the functionality is supposed to provide and then we can look at how we can achieve this.

PS. Off-topic: Not familiar with the MODE key either, is this some alias along the lines of SUPER/windows key?

tags: added: editor ui
Revision history for this message
wl-zocker (wl-zocker) wrote :

The following tools provide a special functionality for the Alt key:
- height
- resources

In both cases, they use the "set" value, i.e. instead of increasing or decreasing the current value, it is set to a fixed number.
Note that the noise height tool also has a "set" value, but it is invoked by the shift key. If we go away from the first/second alternate tool rule, we might consider to change that behavior (new behavior: shift = opposite; Alt = set).
Tools that do not have a second alternate use the first alternate when the Alt key is held down.

Do not wonder that the keys behave strangely, that is bug 1418050.

Revision history for this message
Nasenbaer (nasenbaer) wrote :

this hit me several times as well. Therefore setting to confirmed. With a bit of luck, we find a solution until build19-rc1 :)

Changed in widelands:
status: New → Confirmed
milestone: none → build19-rc1
importance: Undecided → Low
Revision history for this message
SirVer (sirver) wrote :

how about we use a(lternative) and s (next to a) for another tool instead of the modifier keys?

Revision history for this message
GunChleoc (gunchleoc) wrote :

I just tested this again. The left ALT key doesn't work, but the right ALT key does. So, maybe my analysis was wrong and there is a bug in our code.

Revision history for this message
GunChleoc (gunchleoc) wrote :

My analysis was not wrong. Added CTRL to the possible keys and updated help hext,

Changed in widelands:
status: Confirmed → In Progress
assignee: nobody → GunChleoc (gunchleoc)
Revision history for this message
kaputtnik (franku) wrote :
Revision history for this message
kaputtnik (franku) wrote :

My suggestions to the help texts as diff. See https://wl.widelands.org/forum/post/16816/ for the result.

GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
assignee: GunChleoc (gunchleoc) → nobody
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.