Textinput triggers hotkeys
Bug #1390978 reported by
Tino
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Critical
|
Unassigned | ||
Bug Description
If you enter text into the savegame name field or the chat box, the hotkeys are also triggered.
E.g. if you input a "m" fora savegame the minimap windows opens.
Not sure if i caused this with https:/
Related branches
lp:~widelands-dev/widelands/ui_fixes
- Widelands Developers: Pending requested
-
Diff: 1182 lines (+154/-167)38 files modifiedsrc/editor/editorinteractive.cc (+11/-11)
src/editor/ui_menus/editor_player_menu.cc (+1/-2)
src/graphic/graphic.cc (+0/-1)
src/ui_basic/button.cc (+5/-6)
src/ui_basic/editbox.cc (+19/-19)
src/ui_basic/editbox.h (+1/-1)
src/ui_basic/icon.cc (+1/-1)
src/ui_basic/listselect.cc (+5/-5)
src/ui_basic/messagebox.cc (+1/-1)
src/ui_basic/multilineeditbox.cc (+17/-19)
src/ui_basic/multilineeditbox.h (+1/-1)
src/ui_basic/multilinetextarea.cc (+1/-1)
src/ui_basic/panel.cc (+33/-52)
src/ui_basic/panel.h (+28/-16)
src/ui_basic/radiobutton.h (+1/-1)
src/ui_basic/scrollbar.cc (+1/-1)
src/ui_basic/slider.cc (+1/-1)
src/ui_basic/table.cc (+5/-5)
src/ui_basic/textarea.cc (+1/-1)
src/ui_basic/unique_window.h (+1/-1)
src/ui_fsmenu/load_map_or_game.cc (+1/-1)
src/ui_fsmenu/loadgame.cc (+1/-1)
src/ui_fsmenu/options.cc (+2/-2)
src/wlapplication.cc (+2/-2)
src/wlapplication.h (+1/-1)
src/wui/buildingwindow.cc (+1/-1)
src/wui/chatoverlay.cc (+1/-1)
src/wui/game_message_menu.cc (+1/-1)
src/wui/interactive_base.cc (+0/-1)
src/wui/interactive_player.cc (+2/-2)
src/wui/interactive_spectator.cc (+1/-1)
src/wui/shipwindow.cc (+1/-1)
src/wui/soldiercapacitycontrol.cc (+1/-1)
src/wui/soldiercapacitycontrol.h (+1/-1)
src/wui/soldierlist.cc (+1/-1)
src/wui/soldierlist.h (+1/-1)
src/wui/waresqueuedisplay.cc (+1/-1)
src/wui/waresqueuedisplay.h (+1/-1)
| description: | updated |
Revision history for this message
| wl-zocker (wl-zocker) wrote | #1 |
| Changed in widelands: | |
| status: | New → Confirmed |
| tags: | added: regression ui |
Revision history for this message
| SirVer (sirver) wrote | #2 |
| Changed in widelands: | |
| milestone: | none → build19-rc1 |
| importance: | Undecided → High |
| Changed in widelands: | |
| assignee: | nobody → SirVer (sirver) |
| status: | Confirmed → In Progress |
| Changed in widelands: | |
| importance: | High → Critical |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
| assignee: | SirVer (sirver) → nobody |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #3 |
To post a comment you must log in.
I can reproduce this in r7251. It does not happen in r7237 or build-18.
Also notice that the keys behave differently:
- m produces the letter and opens/closes the minimap
- s and c only produce the letter
- n does not produce a letter, but opens the news window instead. It also steals the focus in some way because afterwards, I cannot enter any text anymore in the save dialog.