Terrain names in terrains/init.lua incosistent
Bug #1374831 reported by
TiborB
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Hi
Terrain names in world/terrains/
descname = _ "Mountain 1",
descname = _ "Mountain 2",
descname = _ "Mountain 3",
descname = _ "Mountain 4",
descname = _ "Mountain 1 (Winter)",
descname = _ "Mountain 2 (Winter)",
descname = _ "Mountain 3 (Winter)",
descname = _ "Mountain 4 (Winter)",
Note the parenthesis. Sometimes there are one, sometime there are none.
So I suggest unification. Or alternativelly have parenthesis with world only if the type of terrain is not unique, like "Mountains" in above example.
For more info see also here: https:/
Related branches
lp:~widelands-dev/widelands/bug-1374831
- SirVer: Approve
-
Diff: 588 lines (+83/-57)9 files modifiedsrc/base/i18n.cc (+1/-1)
src/base/i18n.h (+1/-1)
src/editor/tools/editor_info_tool.cc (+26/-0)
src/editor/ui_menus/editor_tool_set_terrain_options_menu.cc (+1/-1)
src/logic/production_program.cc (+7/-7)
src/ui_fsmenu/load_map_or_game.h (+1/-1)
src/ui_fsmenu/loadgame.cc (+1/-1)
src/wui/encyclopedia_window.cc (+1/-1)
world/terrains/init.lua (+44/-44)
Revision history for this message
| GunChleoc (gunchleoc) wrote | #1 |
| Changed in widelands: | |
| status: | New → Confirmed |
| tags: | added: editor lowhangingfruit ui |
Revision history for this message
| TiborB (tiborb95) wrote | #2 |
Revision history for this message
| kaputtnik (franku) wrote | #3 |
| Changed in widelands: | |
| milestone: | none → build19-rc1 |
| assignee: | nobody → GunChleoc (gunchleoc) |
| status: | Confirmed → In Progress |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
| Changed in widelands: | |
| assignee: | GunChleoc (gunchleoc) → nobody |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #4 |
To post a comment you must log in.
I would be comfortable with one of the following 2 options:
1. Rename "Mountain 1 (Winter)" etc. to "Winter Mountain 1" etc.
2. In the terrain editor, we already know it's a Winter mountain, because we will be in the "Winter" tab. So, the only place the names make a difference is the info tool. Is it important there? If the users of the info tool don't care, we could just rename "Mountain 1 (Winter)"etc. to "Mountain 1" etc. We could then also add a terrain category entry to the infotool, the same one we use for the tabs in the terrain tool.
I prefer option 2., but I'm not using the editor myself, so I would like to hear from others on this before I do anything.