Consistent naming of enum members

[GunChleoc]

We don't have a standard for naming enum members. we have UPPERCASE_WITH_UNDERSCORE, lowercase_with_underscore, Title_Case_With_Underscore and CamelCase.

Examples:

enum NodeCaps {
 CAPS_NONE = 0,
 /** can we build normal buildings? (use BUILDCAPS_SIZEMASK for binary
  * masking)*/
 BUILDCAPS_SMALL = 1,
 BUILDCAPS_MEDIUM = 2,
 BUILDCAPS_BIG = 3,
 BUILDCAPS_SIZEMASK = 3,
...
}

enum {
 PCap_Bulldoze = 1, // can bulldoze/remove this buildings
 PCap_Dismantle = 1 << 1, // can dismantle this buildings
 PCap_Enhancable = 1 << 2, // can be enhanced to something
};

enum FlagId {
 FlagStart = 0,
 FlagEnd = 1
};

What do we want here?

[SirVer (sirver)]

We stick to googles style guide (because it is the best documented on the web), so they should be named like constants (which they are): kFlagStart, kBulldoze.

Also, when they are touched they can be converted into enum class {} directly, so that they are in a namespace. FlagId::kStart is saver and reads the same as kFlagStart.

[GunChleoc (gunchleoc)]

Migrated to https://github.com/widelands/widelands/issues/1555