FTBFS when merging latest translations

[Hans Joachim Desserud]

I saw that the daily builds PPA [1] is currently failing to build, even though there hasn't been any code changes since the last successful build.

This narrows down the possible causes quite a bit, so I experimented a bit in my test PPA where I was able to build the latest revision, but it would fail if I merged in the translations branch [2].

I then tried locally what would happen if I attempted to merge the translation branch and rebuild:
[307/647] Generating translations for locale it category world_blackland
FAILED: cd /home/user/widelands/build/po && cmake -E make_directory /home/user/widelands/build/locale/it/LC_MESSAGES && msgmerge -q --no-wrap /home/user/widelands/po/world_blackland/it.po /home/user/widelands/po/world_blackland/world_blackland.pot -o /home/user/widelands/build/po/it_world_blackland.tmp.po && msgfmt -o /home/user/widelands/build/locale/it/LC_MESSAGES/world_blackland.mo /home/user/widelands/build/po/it_world_blackland.tmp.po && cmake -E remove /home/user/widelands/build/po/it_world_blackland.tmp.po
msgmerge: feil under åpning av «/home/user/widelands/po/world_blackland/world_blackland.pot» for lesing: Ingen slik fil eller filkatalog
[307/647] Generating translations for locale it category texts
ninja: build stopped: subcommand failed.

So it looks like it fails due to translations of the old blackland world which doesn't exist in the repo. Not quite sure how to resolve this, but in the mean time I'll remove
merge translations lp:~sirver/widelands/translations
from the recipe so the PPA won't fail everytime it tries to build something.

[1] https://code.launchpad.net/~widelands-dev/+recipe/widelands-daily
[2] https://code.launchpad.net/~hjd/+recipe/widelands-test

[SirVer (sirver)]

I fixed the errors in the translations branch and verified that trunk now builds again without any problems. Could you please reenable merging the translations in the PPAs?

[Hans Joachim Desserud (hjd)]

Thanks for sorting this out.

>Could you please reenable merging the translations in the PPAs?

I would like to, but I'm worried that translations might break the build in the future too. Won't it simply fail the same way the next time someone adds a translation to one of the "don't translate" templates? One thing is trunk breaking due to code changes, but I don't see why unmerged translations should break the build. (Naturally those changes need to be fixed before they are merged to trunk, but still...)

[SirVer (sirver)]

Yes, I think that could indeed be the case. So are you suggesting that we should not merge the translations automatically, but instead merge them more often into trunk or so?

[GunChleoc (gunchleoc)]

I have renamed and deactivated the templates. I can't delete them, so I've asked a Lanchpad question.

https://answers.launchpad.net/launchpad/+question/254133

[Hans Joachim Desserud (hjd)]

GunChleoc: Ok. I saw from your question that it's not possible to remove them completely, though since they aren't visible among the other translation templates it would require some effort to find them.

I've re-added merging translations to the PPAs after verifying the current translation branch worked fine in my test PPA.

SirVer: I thinking merging translations more often would be nice. Sometimes it can take months before the latest changes makes their way into trunk which means it takes longer before people can try how the translations work in practice/context of the game, spot typos etc. So I think that would be an improvement in general. We can still merge the latest translations automatically into the PPA, but I didn't want them to break a build which would otherwise be fine without them.

[SirVer (sirver)]

I put something on my calendar. I try to merge translations once per month now.

[GunChleoc (gunchleoc)]

Let me know if I can do anything to help with the merging.

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.