Dedication server (cli option) core dumps on non-existing files
Bug #1355397 reported by
Hans Joachim Desserud
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
Steps to reproduce:
1. Attempt to run `./widelands --dedicated` specifying an non-existing file. For instance `./widelands --dedicated=
Expected result:
Get an error message saying file doesn't exist.
Actual result:
A core dump, see attached backtrace.
Reproducible in r7450 on Ubuntu 14.10.
Related branches
lp:~widelands-dev/widelands/dedicated_out_of_main
- Tino: Approve
- GunChleoc: Approve
-
Diff: 3599 lines (+457/-1848)25 files modifiedsrc/CMakeLists.txt (+0/-3)
src/io/CMakeLists.txt (+0/-13)
src/io/dedicated_log.cc (+0/-342)
src/io/dedicated_log.h (+0/-90)
src/logic/editor_game_base.cc (+1/-5)
src/logic/game.cc (+56/-108)
src/logic/game.h (+13/-7)
src/logic/game_settings.h (+0/-11)
src/main.cc (+0/-57)
src/map_io/map_building_packet.cc (+1/-2)
src/network/CMakeLists.txt (+0/-1)
src/network/internet_gaming.cc (+21/-22)
src/network/netclient.cc (+47/-163)
src/network/netclient.h (+0/-2)
src/network/nethost.cc (+102/-593)
src/network/nethost.h (+1/-8)
src/network/network_protocol.h (+7/-35)
src/sound/sound_handler.h (+0/-1)
src/ui_fsmenu/launch_mpg.cc (+0/-10)
src/ui_fsmenu/loadgame.cc (+164/-179)
src/ui_fsmenu/mapselect.cc (+39/-113)
src/wlapplication.cc (+2/-77)
src/wlapplication.h (+1/-1)
src/wlapplication_messages.cc (+0/-1)
src/wui/chat_msg_layout.cc (+2/-4)
Revision history for this message
| Hans Joachim Desserud (hjd) wrote | #1 |
| Changed in widelands: | |
| status: | New → Triaged |
| description: | updated |
| Changed in widelands: | |
| assignee: | nobody → SirVer (sirver) |
Revision history for this message
| SirVer (sirver) wrote | #2 |
| Changed in widelands: | |
| status: | Triaged → Fix Committed |
| assignee: | SirVer (sirver) → nobody |
| Changed in widelands: | |
| milestone: | none → build19-rc1 |
| tags: |
added: network removed: dedicated |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #3 |
To post a comment you must log in.
--dedicated is gone, so this bug is gone too.