widelands

Constructionsites/dismantlesites only show a dot instead of building image

Bug #1344350 reported by wl-zocker
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Low
Unassigned
widelands build19-rc1

Bug Description

Noticed in r7119.
When you click on a constructionsite, a window opens showing the missing wares. In the background, the building being constructed used to be shown. This is no longer the case, only a strange dot is shown.
Same goes for the dismantlesite.

Tags: regression ui

Related branches

lp:~widelands-dev/widelands/bug-1344350
SirVer: Approve
Diff: 95 lines (+21/-7)
6 files modified
src/economy/test/test_routing.cc (+1/-1)
src/logic/building.cc (+1/-1)
src/logic/building.h (+4/-0)
src/logic/partially_finished_building.cc (+11/-0)
src/logic/partially_finished_building.h (+3/-4)
src/wui/buildingwindow.cc (+1/-1)
Revision history for this message
Hans Joachim Desserud (hjd) wrote :

Indeed.

The background image is displayed as expected for fully constructed buildings though...

Changed in widelands:
importance: Undecided → Low
milestone: none → build19-rc1
status: New → Confirmed
Revision history for this message
SirVer (sirver) wrote :

This happened when get_ui_anim() was moved to the Descriptions classes (out of the objects). The ui_anim() of a constructionsite should be the one of its building_in_construction. Since the constructionsite::Descr cannot know what the future building will be, the constructionsite has to provide this information.

So get_ui_anim() has to be moved back into the building class and must be overwritten by the constructionsite (or rather by the partially constructed building).

Hans Joachim Desserud (hjd)
Changed in widelands:
status: Confirmed → Triaged
GunChleoc (gunchleoc)
Changed in widelands:
assignee: nobody → GunChleoc (gunchleoc)
GunChleoc (gunchleoc)
Changed in widelands:
status: Triaged → In Progress
Revision history for this message
SirVer (sirver) wrote :

Fixed in r7140.

Changed in widelands:
status: In Progress → Fix Committed
GunChleoc (gunchleoc)
Changed in widelands:
assignee: GunChleoc (gunchleoc) → nobody
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.