Building help: clean up name, descname

[GunChleoc]

This bug will need attention after https://code.launchpad.net/~widelands-dev/widelands/bug-1074353 has been merged.

Comment from SirVer:

- Some of the wrapped lua objects (building, workers) have methods that are now on the description (like name, descname). They must be removed and the descr() methods used instead. This should also be done before b19, because then we have to guarantee some form of backwards compatibility again.

[GunChleoc (gunchleoc)]

Looking at worker.h, we have quite a bunch of those:

 const Image* icon() const {return descr().icon();}
 Ware_Index becomes() const {return descr().becomes();}
 Ware_Index worker_index() const {return descr().worker_index();}
 const Tribe_Descr & tribe() const {return descr().tribe();}
 const std::string & descname() const {return descr().descname();}

and more.

Do you want them all gone?

[SirVer (sirver)]

Yes, I think removing the forwarding methods will make the interface of worker clearer.

[SirVer (sirver)]

Do one at a time (per merge request though) to keep changes smaller and closer to trunk.

[GunChleoc (gunchleoc)]

Will do :)

[GunChleoc (gunchleoc)]

I will do one MapObject type at a time; these are local properties, so there's not need to have a separate branch for each property. name/descname and the type name in the other bug are the big ones.

[GunChleoc (gunchleoc)]

OK, all done in 4 branches, plus the name/descname in the buildhelp branch.

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.