widelands

Called C++ object pointer is null in logic/ware_descr.cc

Bug #1335430 reported by Hans Joachim Desserud on 2014-06-28

This bug report is a duplicate of: Bug #1322869: dedicated server broken due to calls to g_gr. Edit Remove

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	widelands	Confirmed	Low	Unassigned	widelands build19-rc1

Bug Description

Found by scan-build in r7020.

I don't know how strongly this is related, but it might be relevant to read through bug 1322869 when looking at this one.

Last seen in r7181.

See original description

Tags:

Revision history for this message

Hans Joachim Desserud (hjd) wrote on 2014-06-28:

report-3f64a9.html Edit (11.1 KiB, text/html)

Revision history for this message

SirVer (sirver) wrote on 2014-06-30:

This will crash in --dedicated.

However the correct fix is to have a dummy g_gr object that does nothing for dedicated anyways. Checking that g_gr != nullptr everywhere is not scalable.

Changed in widelands:
status:	New → Confirmed
milestone:	none → build19-rc1

Hans Joachim Desserud (hjd) on 2014-09-21

description:

updated

Revision history for this message

Hans Joachim Desserud (hjd) wrote on 2014-10-12:

(This was not found in r7207, though the code hasn't changed since r7181, so this cannot possibly be fixed. I ran scan-build 3.6 which is the current development version so there might be a regression there.)

Revision history for this message

SirVer (sirver) wrote on 2016-02-05:

Not a strict duplicate, but the fix for 1322869 will fix or invalidate this bug as well.