Segfault when loading a game with nightly build

[Reijo Tomperi]

I installed widelands nightly build, played and saved it. When I few hours later tried to load the game, I got segfault. I'm adding the saved game as an attachment.

$ widelands --version
Widelands bzr6952-201404210632(Release)

...
Vision check successful for player 2
Vision check successful for player 3
Vision check successful for player 4
took 20ms
 Reading Player Message Data ... took 0ms
 Reading Objective Data ...
Program received signal SIGSEGV, Segmentation fault.
0x00007ffff5f57189 in std::string::assign(std::string const&) ()
   from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
(gdb) bt
#0 0x00007ffff5f57189 in std::string::assign(std::string const&) ()
   from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#1 0x0000000000835b84 in Widelands::Map_Objective_Data_Packet::Read(FileSystem&, Widelands::Editor_Game_Base&, bool, Widelands::Map_Map_Object_Loader&) ()
#2 0x000000000068075d in Widelands::WL_Map_Loader::load_map_complete(Widelands::Editor_Game_Base&, bool) ()
#3 0x00000000005fea23 in Widelands::Game_Map_Data_Packet::Read_Complete(Widelands::Game&) ()
#4 0x00000000005ff76e in Widelands::Game_Loader::load_game(bool) ()
#5 0x0000000000715a56 in Widelands::Game::run_load_game(std::string, std::string const&) ()
#6 0x000000000055654d in WLApplication::load_game() ()
#7 0x00000000005572de in WLApplication::mainmenu_singleplayer() ()
#8 0x0000000000557c50 in WLApplication::mainmenu() ()
#9 0x0000000000558240 in WLApplication::run() ()
#10 0x000000000054b9fb in main ()

[Hans Joachim Desserud (hjd)]

Thanks for reporting this issue.

At the moment I run into bug 1311790 when attempting to load this, but I will take a closer look once that has been resolved.

[SirVer (sirver)]

This bug has been fixed in r6954

[Albert Einstein (w-aaaaa)]

I'm not sure if it is the same bug. In my version of Widelands (bzr6958) there was a problem with saving a huge map "The maze v.1.1". After trying to open the saved game I've got a message:
"Command queue: build: x coordinate is 16872 but width is only 368"
In autosave file is the same problem, with different number :)
Saved game in the attachement.

Using OS: Windows 7, Virtual machine
Using version of Widelands: bzr6958

[SirVer (sirver)]

The error in #4 comes from the same place that I fixed for this bug. Are you positive that you did not start this game with < r6954, reloaded and continued on? I am unsure how invalid coords could have slipped through in the current code - but the code is complex and brittle, so I cannot rule it out completely.

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.