build completion status not translated

Bug #1278583 reported by Kai
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Low
Unassigned

Bug Description

This is just a minor minor bug - just wanted to report it anyway. It looks like even with the 18rc some strings are not translated. I've noticed it with the build status.

Steps to reproduce:
- start widelands
- create a new game
- enable display of building statistics
- start to build any building
- instead of a translated text (e.g. "0 % fertiggestellt" the english text "0 % build" is displayed.

Related branches

Revision history for this message
Kai (nospam-kaigrabfelder) wrote :
Revision history for this message
Hans Joachim Desserud (hjd) wrote :

Thanks for taking your time to report this issue.

It does indeed seem like this string is not translatable. I grepped for it in the source, and found it in two places. (I wonder if it might be an idea to split out "% built" from the longer string and make that part only translatable. Reduce the risk of a type breaking the tags or formating)

$ grep -rin "% built" .
./logic/immovable.cc:545: (boost::format("<font color=%1$s>%2$i%% built</font>") % UI_FONT_CLR_DARK_HEX % percent).str();
./logic/constructionsite.cc:91: (boost::format("<font color=%1$s>%2$i%% built</font>") % UI_FONT_CLR_DARK_HEX % percent).str();

PS. Please mention which language you are playing the game in another time, this makes it easier to search in the translated strings to see whether it is a general issue or only affecting a single language.

Changed in widelands:
importance: Undecided → Low
status: New → Confirmed
GunChleoc (gunchleoc)
Changed in widelands:
assignee: nobody → GunChleoc (gunchleoc)
GunChleoc (gunchleoc)
Changed in widelands:
status: Confirmed → In Progress
GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
Changed in widelands:
milestone: none → build19-rc1
GunChleoc (gunchleoc)
Changed in widelands:
assignee: GunChleoc (gunchleoc) → nobody
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.