Statistic window displays graph incorrectly when in hour-mode

Bug #1243700 reported by wl-zocker on 2013-10-23
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
widelands
Low
Lukasz

Bug Description

As you can see in the attached screenshot, the black and the white line cross at -60 minutes. When you switch to the hour-mode, the intersection is not at -1, but before (-0.7 or so).
When you save a game you have played for 3 hours (according to the stats), in the load game dialog the time 4:30 is shown (what is a factor of 1.5). So I think the minutes are drawn and calculated correctly, but the hours are wrong.
Tested in r6812.

Related branches

wl-zocker (wl-zocker) wrote :
tags: added: statistics ui
SirVer (sirver) on 2013-10-23
Changed in widelands:
status: New → Confirmed
importance: Undecided → Low
tags: added: lowhangingfruit
Tino (tino79) wrote :

Cannot reproduce this any more with r6892.
Feel free to reopen if necessary.

Changed in widelands:
status: Confirmed → Incomplete
wl-zocker (wl-zocker) wrote :

Did you only try the hour mode or also the game mode? I just checked it (r6890) and the normal hour mode (e.g. 5h) seems fine, but when I have the whole game time displayed, I have the factor 1.5 again (1h game = 1.5 h hour mode = 90 minutes).

Launchpad Janitor (janitor) wrote :

[Expired for widelands because there has been no activity for 60 days.]

Changed in widelands:
status: Incomplete → Expired
SirVer (sirver) wrote :

I can still see this.

Changed in widelands:
status: Expired → Confirmed
SirVer (sirver) wrote :

Setting to incomplete for bug sweeping.

Changed in widelands:
status: Confirmed → Incomplete
Launchpad Janitor (janitor) wrote :

[Expired for widelands because there has been no activity for 60 days.]

Changed in widelands:
status: Incomplete → Expired
SirVer (sirver) on 2015-01-08
Changed in widelands:
status: Expired → Confirmed
TiborB (tiborb95) wrote :

fixed in rev 7455

Changed in widelands:
status: Confirmed → Fix Committed
assignee: nobody → Lukasz (majcherlk)
Changed in widelands:
milestone: none → build19-rc1
GunChleoc (gunchleoc) on 2016-10-25
Changed in widelands:
status: Fix Committed → Fix Released
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

Niektory (niektory) wrote :

This is still occuring in recent versions (bzr9141). The time on the axis in the statistics window is shown incorrectly if the slider is set to "game" and the game length is between 32 and 38 hours. See the attached screenshot: the game has been going for over 32 hours but the labels on the time axis indicate it started 25 hours ago.

Niektory (niektory) wrote :

Attached a fix.

GunChleoc (gunchleoc) wrote :

How do the labels on the time axis indicate it started 25 hours ago? We have 10h, 30h, game in the screenshot.

It would also help to have the savegame for testing.

Toni Förster (stonerl) wrote :

On the x-axis the plot starts at 25h, if the game has started 32hrs ago then we should see the plot start at the 32h mark. Also, the x-axis starts at -26h so there are about 10hrs missing or falsely drawn.

Niektory (niektory) wrote :

Here's how the graph looks in the same game after applying my patch - the time on the leftmost label shows -34 hours, which is correct considering the game was played for a little over 32 hours according to the timer in the corner of the screen. It was showing -26 before applying the patch.

Niektory (niektory) wrote :

And here's a save for testing, saved after 32 hours and 16 minutes of playing. The incorrect labels appear when the game time is between 32 and 34 hours, or between 36 and 38 hours.

Niektory (niektory) wrote :

Continued in bug #1840087 - sorry for the chaos

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers