Strange Lua script behaviour after starting MP game with saved game

[Nasenbaer]

In Our WLT2013 game (Game 10), the host lost the internet connection two times, therefore we had to reload the game from a saved game, however it seems this reload lead to a strange Lua bug.

First of all, the message of "the game will end in X minutes" showed "153minutes" in every message after the reload.

Second of all: once I conquered 50% of the land, the we got the message, that I have to hold the land for 12 minutes. after 12 minutes nothing happend. instead we received a message after roughly 30 minutes, that I should hold at least those 50% of the lands for -23 further minutes. So a negative value.
After that message, the message apperead every 5 minutes until 4 hours were over and I finally won the game

So the 4 hours counter seemd to be running correctly, but all the other counters behaved strangely.

[SirVer (sirver)]

mmh - we had reports of errors in saved lua games before. Did you send over the savegame file, so that maybe a savegame from another computer was loaded on your system? (it should not have mattered though).

Some of the counters are correct though - I have a feeling as if closure variables are not correctly saved.

I believe the best fix is to move over to https://github.com/fnuecke/eris/, which seems much more solid groundwork than what we have right now instead of debugging this. However, this costs savegame compatibility :).

[Nasenbaer (nasenbaer)]

@#2 yes the save game was from the host and was automatically exchanged during loading process. However the behaviour was the same on both host and client side - so for the host it was his own savegame

[SirVer (sirver)]

I started working a bit on this by integrating with eris. I added eris to our build and started doing the necessary ports to get our stuff running on Lua 5.2 (which eris integrates with). This will break safegame compatibility, but it seems to be reasonably easy to move forward with this.

I would suggest we use the change to get rid of compatibility code in Widelands in loading too, because this will be incompatbile anyways.

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.