Lots of warnings "internationalized messages should not contain the '\r' escape sequence" when doing make lang

[Jens Beyer]

"internationalized messages should not contain the '\r' escape sequence"

This message comes alot when doing make lang with latest trunk.

The en_GB translation does this.

Of course one can fix this. But since this happens often enough and still is not enforced by Launchpad/Rosetta (there is still an open bug on this) we might consider doing something about this like failing the build when this happens, making sure this gets fixed quickly.

[Jens Beyer (qcumber-some)]

By the way, the Launchpad bug is Bug 560652

[SirVer (sirver)]

We have already utils/find_lf_in_translations.py which finds all the occurrences of this problem. I am not sure why this script does not go the extra mile and fix those too, but at a quick glance it seems like this should be possible to be added easily. Volunteers?

[Jens Beyer (qcumber-some)]

This raises a question which I was wondering for a while.

What happens if we fix those \r\n in trunk .po files and commit them - do they appear fixed in the Launchpad translation services?

[SirVer (sirver)]

> What happens if we fix those \r\n in trunk .po files and commit them - do they appear fixed in the Launchpad translation services?

I have no idea - that might be the reason why fixing is not implemented in the script, because they are not reimported. But I honestly do not know. Might be worth running an experiment.

But even if they are not reimported - we could just run this script in the translations branch every now and then (like daily) and get rid of the problem this way too.

[SirVer (sirver)]

Setting to incomplete for bug sweeping.

[Hans Joachim Desserud (hjd)]

GunChleoc: Do you know what might happen if we committed fixed versions of this, or whether there's a better way to fix it?

PS. I'm not tasking you to fix this, so feel free to unassign yourself again. :)

[GunChleoc (gunchleoc)]

I never looked into this, because it is a Lanchpad bug.

If you open the misbehaving files in an intelligent text editor like Geany and save, it should fix the line endings for you. You could also try Virtaal on Linux. Since po files are technically text files, any good editor will do.

We could also contact the translators working on the misbehaving files to ask which editor they are using and recommend a new editor to them.

[SirVer (sirver)]

Relevant: utils/find_lf_in_translations.py

this script will detect those errors and can easily be modified to fix them.

[GunChleoc (gunchleoc)]

Since we have this script, can this bug be marked as "Fix Commited"?

[SirVer (sirver)]

I think so. Do we have a process to run it regularly though?

[GunChleoc (gunchleoc)]

Not officially, but it's part of the sh script we're both using to merge translations & update catalogs.

[SirVer (sirver)]

How about we check that script into utils. That makes it kind of official and more visible :)

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.