Widelands crashes due to economy error

[Martin Buchwald]

I am playing bzr6726[trunk](Release) on Windows 7 and the map "Trident of Fire" in scenario mode.

The error text is as follows:
[c:/data/bzr/widelands/trunk/src/economy/economy.cc:651] Economy::find_best_supply: COULD NOT FIND A ROUTE!

[Martin Buchwald (martinbuchwald)]

Here is the replay file

[Nasenbaer (nasenbaer)]

This is just guessing from a quick look on the game, however it seems the script of the map breaks some connections of one economy dividing it to two economies without sending an update request to them... most likely this is done by breaking a sea connection and therefore splitting a fleet (which in game is still treated as one, but can't find a route from one to another port)

[SirVer (sirver)]

feel free to retarget, Nasenbaer if you think this is not a crucial thing.

[Nasenbaer (nasenbaer)]

I will take a closer look at this issue in the next few days (or at least try to ;) )

[Nasenbaer (nasenbaer)]

Well... my guess was false. :-/

@ Martin Buchwald: unfortunally your replay is incomplete therefore I cannot open and use it. Can you please upload the missing wgf file or tell us a way how to reproduce the bug?

I retried to reproduce based upon my idea of a broken seafaring route, but actually the case where a seafaring route is suddenly broken does not lead to an error (and therefore not to the one described here).

[Martin Buchwald (martinbuchwald)]

Hello Nasenbaer,
I guess that this file was missing. Sorry for that.
Sadly I cannot tell you another way to reproduce the bug.

But I think I know that the separation of fleets didn't take place during the game.
Maybe volcano eruptions habe destroyed roads a couple of times?
The error seems to have occured in an instant when automatical saving took place.

[Nasenbaer (nasenbaer)]

Thank you Martin Buchwald for uploading the second part of the replay.
Unfortunally the replay does not give a hint of why the error occured. At the moment I can not reproduce the bug and haven't faced the bug myself until now, so I remove the target milestone build18-rc1.

Any idea on how to trigger this bug reliable is very welcome.

[_aD (ad-simplypeachy)]

I've just encountered this on a map (UK_11) without seafaring.
Map: https://wl.widelands.org/maps/uk_11/

Unfortunately I haven't been able to re-create this. I think a builder had just finished building a bakery when the crash happened.

[Launchpad Janitor (janitor)]

[Expired for widelands because there has been no activity for 60 days.]

[SirVer (sirver)]

this bug seems confirmed, though it seems hard to repro. setting to confirmed for now, but do not target since we have no idea how to trigger it.

[SirVer (sirver)]

Setting to incomplete for bug sweeping.

[Launchpad Janitor (janitor)]

[Expired for widelands because there has been no activity for 60 days.]

[tokgeo (g.t)]

I played the map "The pass trough the mountains" with 6 Players (edited). After 3 minutes, the error occured.
Used version: Build 18 (Release)

[TiborB (tiborb95)]

Oh, I found a problem - missing brackets after if : http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/src/economy/economy.cc#L688.

[TiborB (tiborb95)]

I was probably wrong :( I am taking it back...

[TiborB (tiborb95)]

Well, at least something: in build 18 there was "throw exemption" - it was removed and replaced with simple log(). I think throw exemption was overkill and game is able to cope with situation when road is not found, though it should not happen, because every two flags in single economy must be connectable by roads&ships...

[GunChleoc (gunchleoc)]

I just played a long game of Trident of Fire, and no crash.

[GunChleoc (gunchleoc)]

I played a game with the map from #14 in Build 18 for a while and encountered no problems.

There will be some changes to economy and routing soon anyway, so I'm closing this bug.

[Launchpad Janitor (janitor)]

[Expired for widelands because there has been no activity for 60 days.]