Terrains not translateable - feature not a bug???

Bug #1215075 reported by Nasenbaer on 2013-08-21
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Low
Unassigned

Bug Description

In revision 6181 a branch from Angelo Locritani was merged : http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/revision/6181

Said branch introduced defineable names for terrains, which may differ from the actual used name (e.g. greenland terrain wasser.png is now shown as "Water") However the descrname()s are not marked for translation, which seems to be a feature as stated in the terrainconf:

##### Name strings are not translatable by purpose: this way mapmakers can share
##### suggestions without having to worry about the localized name of terrain

I am unsure, if maybe I shared that opinion back when the change was introduced :-D ... anyways I clearly disagree nowadays.

I haven't seen discussions about specific terrainnames so far and even if there were some, they would either be in localized forums (so localisation would not matter) or people would write e.g. in English and would translate all parts of the game anyways.

So I really do not see a reason for a special casing - more I see a reason to enable translation as most likely all none English speaking users of our Editor have no clue of the English names currently shown.

Any other opinions?

Nasenbaer (nasenbaer) on 2013-08-21
Changed in widelands:
status: New → Incomplete
Hans Joachim Desserud (hjd) wrote :

Previously discussed in bug 584576.

Nasenbaer (nasenbaer) wrote :

As nobody spook up against this change I just made it happen and committed a fix. Please reopen the bug if someone complains :)

Changed in widelands:
status: Incomplete → Fix Committed
importance: Undecided → Low
SirVer (sirver) wrote :

Released in build-18 rc1.

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers