widelands

Use composition over inheritance for ChatProvider

Bug #1214775 reported by cghislai
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Won't Fix
Low
Unassigned

Bug Description

The chatprovider superclass should be use in a composition pattern rather than inherited by subclasses. Additionally, boost signals may be used to setup a chatprovider.

Tags: chat cleanups
Revision history for this message
cghislai (charlyghislain) wrote :

See https://code.launchpad.net/~widelands-dev/widelands/log_messages/+merge/177712/comments/408688

Hans Joachim Desserud (hjd)
Changed in widelands:
status: New → Triaged
Revision history for this message
SirVer (sirver) wrote :

Setting to incomplete for bug sweeping.

Changed in widelands:
status: Triaged → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for widelands because there has been no activity for 60 days.]

Changed in widelands:
status: Incomplete → Expired
Revision history for this message
Hans Joachim Desserud (hjd) wrote :

(Assuming no one has fixed this in the meantime)

Setting to triaged since the description is quite clear and the review comment includes a suggestion for how to procede.

Changed in widelands:
status: Expired → Triaged
tags: added: cleanups
removed: refactoring
Revision history for this message
GunChleoc (gunchleoc) wrote :

Migrated to https://github.com/widelands/widelands/issues/1463

Changed in widelands:
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.