"Follow" function in watch window crashes in replays or when playing as a spectator

[wl-zocker]

I guess the title says it all. Tested in r6880, no useful output in stdout.

I do not know if related, but when I follow a worker via that feature in a normal game, the watch window seems to "hang" for short moments. This is not the case in the main window.

[Hans Joachim Desserud (hjd)]

Thanks for noticing and reporting this issue.

I am also able to trigger this when playing a multiplayer game as spectator, and the error message does indeed indicate this could be the reason:
Program received signal SIGSEGV, Segmentation fault.
0x0000000000ac56df in Interactive_Player::player (this=0x0) at /home/user/widelands/src/wui/interactive_player.h:68
68 return game().player(m_player_number);

I believe there should be a stderr file in the same place as stdout on Windows, so you might want to check that for more information in the future. :)

[wl-zocker (wl-zocker)]

There is indeed a stderr file, but it is always empty (I check it immediately after the crash). I do not know when something gets written there.

[SirVer (sirver)]

Is it positive that this is a regression? I mean could it not be that this was already in b17?

[wl-zocker (wl-zocker)]

In b17, the game crashes as soon as I click "follow" (specatator in multiplayer game).

[cghislai (charlyghislain)]

My guess is that the code assume interactive_player is not null.

[wl-zocker (wl-zocker)]

Since one can follow wild animals and even the enemies' workers, I do not understand why an interactive player is needed. It would be nice to have that feature, e.g. in a replay I wanted to follow a ship making an expedition. If that is not possible (for whatever reason), the button should be greyed out to prevent the game from crashing.

[SirVer (sirver)]

I agree that this should be possible - it is even more useful when you are observer or watching a replay then when you are not. I agree with charlys assessment too.

[Hans Joachim Desserud (hjd)]

>Is it positive that this is a regression?
>In b17, the game crashes as soon as I click "follow" (specatator in multiplayer game).

Ok, not sure what happened or if I did something wrong but when I tried it in b17 I didn't get it to crash. I am perfectly able to reproduce the crash in b17 now though, so it is not a regression. Sorry about that.

[SirVer (sirver)]

Released in build-18 rc1.