Value stored to unread variable in map_io/widelands_map_buildingdata_data_packet.cc

[Hans Joachim Desserud]

On line 271 map_io/widelands_map_buildingdata_data_packet.cc, the variable done is assigned the value true. However, the next line breaks out of the loop and that variable is never read beyond that point.

Found by scan-build in r6675.

[cghislai (charlyghislain)]

yes that var is useless. The block could be replaced by
 // iterate through all buildings to find first predecessor
 const Tribe_Descr & t = b.descr().tribe();
 while (true) {
  const Building_Descr * oldest = b.m_old_buildings.front();
  if (!oldest->is_enhanced()) {
   break;
  }
  const Building_Index & oldest_idx = t.building_index(oldest->name());
  for (Building_Index i = Building_Index::First(); i < t.get_nrbuildings(); ++i) {
   Building_Descr const * ob = t.get_building_descr(i);
   if (ob->enhancements().count(oldest_idx)) {
    b.m_old_buildings.insert(b.m_old_buildings.begin(), ob);
    break;
   }
  }
 }
}

[SirVer (sirver)]

Fixed in r6677.

[SirVer (sirver)]

Released in build-18 rc1.