Wincondition scripts reloaded too often

[cghislai]

When you enter the load replay window, all win condition scripts are loaded once for each replay - probably during preloading.
The scripts should only be loaded once, at the start of the game.

[SirVer (sirver)]

Why do you consider this a bug? I mean, yes it could be done more performanently, but I do not notice any delay. Lua is very fast and the delay of going to disk (for the replay itself) is already paid, so it should not matter.

[cghislai (charlyghislain)]

It is quite slow here, a few full seconds before the list appear, while all the logs about loading scripts scroll in the background. I doubt it is my terminal slowing the whole thing down. I will profile that

[SirVer (sirver)]

Well, I have a solid state disk, so the seeks could be the culprit. Should be easy to only load this once though: just keep a Lua Interface around - they cash the script names and/or you can cash the LuaTables returned from the win conditions.

[cghislai (charlyghislain)]

There is a fix for this. create the game object in wlapplication, similar to what is done for the load game dialog. The Game preload data paquet object can be created outside of the loop, too.

[Nasenbaer (nasenbaer)]

As far as I understand, the fix is committed- > fix committed

[SirVer (sirver)]

Released in build-18 rc1.