Save game claims win condition is Scenario, even when it isn't

[Hans Joachim Desserud]

Steps to reproduce:
1. Start a new game with a win condition like collectors or endless game.
2. Save said game.
3. Look at the save game in either the save or the load game dialog.

Expected result:
The win condition from step 1 should be listed.

Actual result:
For some reason they all list Scenario, no matter what I have selected.

Wondering if the translated names didn't match and trigger some default type, I tried switching the game to English which had the same results. When I browse the games listed in the load game dialog I notice older games list the correct win conditions.

widelands r6626 on Ubuntu 13.04.

[cghislai (charlyghislain)]

Indeed something is wrong with my code, sometimes the win condition is stored as the script name, sometimes as the translated name, i may have to check for version.
I will also allow showing current game info in the save dialog if no game is selected.

[Hans Joachim Desserud (hjd)]

Hm, it seems like this has reversed now. If I start a new game with a selected win condition, the save game will list that win condition. So far, so good. However, if I check the Scenario checkbox for a game or start a new campaign game, the save game will claim win condition is "Not Set". Is this intended? :)

(I also have a couple of save games which display "not_set", though I am not sure why that would be. I think they are all quite old, in case that matters though)

[cghislai (charlyghislain)]

of course not intended..
This is strange because code to handle scenario is still in there, so with newly saved game this should be correctly set, but I have the same issue here.
I will check that and ensure it works for former version as well, in those it was stored as "not_set".
Thanks for checking!

[cghislai (charlyghislain)]

I'm reopening this one, there are still inconsistencies and I see the "Not set" too often.

[Hans Joachim Desserud (hjd)]

For build18, should we simply hide the win condition for the save game, load game and replay dialogs? As long as we cannot present it consistently, we might as well not show it to the user to avoid confusion. Then, once we figure out whatever is plaguing this, we can instead introduce this feature in build19.

[SirVer (sirver)]

I think it is useful to show this. maybe we get more bug reports that will help us track the issue down.

[wl-zocker (wl-zocker)]

I think the problem is that the win condition is not loaded correctly:
- Start a game, choose a win condition, save the game, exit it.
- The correct win condition is shown in the load dialog (i.e. it has been saved correctly).
- Load the game, save it again and exit.
- In the load dialog, the win condition is "not set".
At least that is the case in r6910.

[SirVer (sirver)]

Setting to incomplete for bug sweeping.

[wl-zocker (wl-zocker)]

The observations from #7 are still valid in r7199.

[GunChleoc (gunchleoc)]

I think the problem is that the win conditions are localized before they are saved into the savegame. I noticed this while working on the UI overhaul, but changing this isn't as trivial as I thought. We do need to fix this though.

[GunChleoc (gunchleoc)]

I did a test with the game set to English, and this still happens. So, it is not related to the wrong localization, which is a different problem.

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.