Warnings with newer libpng versions (iCCP: known incorrect sRGB profile)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Widelands media development |
Fix Released
|
Undecided
|
kaputtnik | ||
widelands |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
When running Wl (recently built from source on Arch) I have lately been getting long lists of warnings saying the following:
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
...
Per, for example, http://
I wouldn't have reported this except for the fact that the fix is very simple with imagemagick. A large number of .png images in the Wl source have these incorrect profiles, but I got imagemagick to convert them en masse:
cd /usr/share/
for i in `find . | grep .png`; do convert "$i" -strip "$i"; done
As it goes through, imagemagick will print:
...
convert: iCCP: known incorrect sRGB profile `./tribes/
convert: iCCP: known incorrect sRGB profile `./tribes/
convert: iCCP: known incorrect sRGB profile `./tribes/
...
But it will fix these problems, and the warnings from libpng when running Wl will be no more. If a similar process were done on the main Wl trunk, this would save users from having to do it themselves as the less-bleeding-edge distros begin to update to the new libpng.
Related branches
- Tino: Approve
- SirVer: Approve
-
Diff: 76 lines (+0/-0)0 files modified
Changed in widelands: | |
status: | Confirmed → Fix Committed |
Changed in widelands-media: | |
assignee: | nobody → kaputtnik (franku) |
status: | New → Confirmed |
Changed in widelands-media: | |
status: | Confirmed → Fix Committed |
tags: |
added: cleanups removed: libpng |
Changed in widelands: | |
status: | Fix Committed → Fix Released |
Changed in widelands-media: | |
status: | Fix Committed → Fix Released |
Thanks for the report and the fix. This is very useful.
I think we must do this, the question is just when: when we do this, all .png files in the repo will change which will blow up the repo and be a huge commit. I suggest waiting till shortly before the next release (when we will also en masse pngoptimize the .pngs again I guess) to do this. What do others think?