Opening a Widelands file makes all strings appear in English

Bug #1171233 reported by wl-zocker on 2013-04-21
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Low
Tino

Bug Description

Tested in r6559 on Windows 7

When I open Widelands normally (via the exe, I end up in the main menu), all the strings appear in my desired language (German) equal whether I play a game or edit a map.
But if I open a wgf (savegame) or wmf (map) file via double click in the Windows explorer and the game starts/the editor opens, all the strings are shown in English (the default language, I guess).
It would be nice if the strings are shown in the chosen language. The other configuaration (e.g. resolution) are as set in the options menu.

SirVer (sirver) wrote :

I didn't even know opening a maps file from the shell is possible :)

likely the --localedir command is not properly set.

Changed in widelands:
status: New → Confirmed
importance: Undecided → Low
Nasenbaer (nasenbaer) wrote :

Jepp wgf files as are assigned to Widelands on Windows :). This is done via an registry entry set by the setup:

[Registry]
Root: HKCR; Subkey: .wgf; ValueType: string; ValueName: ; ValueData: WidelandsSavegame; Flags: uninsdeletevalue
Root: HKCR; Subkey: WidelandsSavegame; ValueType: string; ValueName: ; ValueData: Widelands Savegame; Flags: uninsdeletekey
Root: HKCR; Subkey: WidelandsSavegame\DefaultIcon; ValueType: string; ValueName: ; ValueData: {app}\{#ExeName},0
Root: HKCR; Subkey: WidelandsSavegame\shell\open\command; ValueType: string; ValueName: ; ValueData: """{app}\{#ExeName}"" ""--loadgame=%1"""

The problem could be solved either through defining the workingdir of Widelands (so the Widelands directory) or - as SirVer suggested - by passing --localedir={app}\locale

Tino (tino79) wrote :

I'll take a look at this this weekend.

Changed in widelands:
assignee: nobody → Tino (tino79)
Tino (tino79) wrote :

I've pushed a fix for it.
But i think, widelands behaves a bit weird:
- you can't set a working dir in the registry for the app, the app should be able to run without it
- setting --datadir is not necessary, when set it does not get saved to config file
- setting --localedir gets saved to widelands config file

In my opinion widelands should always look for data/language files relative to it's own executable when no values are set by commandline or config file.

Changed in widelands:
milestone: none → build18-rc1
status: Confirmed → Fix Committed
SirVer (sirver) wrote :

Released in build-18 rc1.

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers