Revision 6559 FTBFS on GNU/Linux due to compile_assert failing
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Critical
|
Unassigned |
Bug Description
With revision 6559, WL fails to build on GNU/Linux (tried with Ubuntu and Arch) with the following error message:
Scanning dependencies of target widelands_all
[ 1%] Building CXX object src/CMakeFiles/
In file included from /home/arch/
/home/arch/
#define compile_assert(x) typedef bool TOKENPASTE2(
/home/arch/
compile_
^
make[2]: *** [src/CMakeFiles
make[1]: *** [src/CMakeFiles
make: *** [all] Error 2
r6558 worked fine, and it also seems pretty clear from the commit message[1] this change caused the problem. I guess we will need to either
A) wrap this in IFDEFs to support all platforms (which sounds messy), or
B) find some better way to do this check
[1] http://
Sorry, my fault. Somehow i thought the check is <= instead of ==.
Now using #defs to determine win32 platform.