List of workers in building window not updating properly

Bug #1132469 reported by Hans Joachim Desserud on 2013-02-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Low
cghislai

Bug Description

Steps to reproduce:
1. Build some building and wait for it to finish.
2. Open the building window and if necessary switch to the workers tab.
3. Verify the worker is listed as "coming"
4. Keep the window open and wait for the worker to enter the building.

Expected result:
Upon entering, the window is updated, listing the worker as present.

Actual result:
Unless you hover the cursor over some part of the window or otherwise do something no update will be triggered.

This sounds suspisciously similar to bug 726139 if you ask me, so a similar fix might work here too.

Widelands bzr r6515.

Related branches

Nicolai Hähnle (nha) on 2013-02-24
Changed in widelands:
status: New → Confirmed
SirVer (sirver) wrote :

We recently had a fix for a similar problem, but for the warelists not being updated properly. A similar solution should be applied here (essentially, making the building an Observable with a boost::signal (that might need to be mutable) which is called whenever its state changes - the Window will then register with this signal and redraw when it is triggered.

Changed in widelands:
status: Confirmed → Triaged
Changed in widelands:
assignee: nobody → cghislai (charlyghislain)
Changed in widelands:
status: Triaged → In Progress
Hans Joachim Desserud (hjd) wrote :

I'm no longer able to reproduce this issue in r6643.

Changed in widelands:
milestone: none → build18-rc1
status: In Progress → Fix Committed
SirVer (sirver) wrote :

Released in build-18 rc1.

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers