widelands

Connection lost after some time if all players pause in multiplayer

Bug #1027058 reported by Johannes Ebke
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Medium
Unassigned
widelands build18-rc1

Bug Description

In a two-player direct IP game over the internet (bzr6417), we observed that when both players pause the game (for example for dinner), the connection silently drops after some time.

This is probably since a widelands-ping is only sent if one of the clients forces a wait, but not if the players agree to pause. I will push a fix momentarily, which however has only been tested locally yet.

Related branches

lp:~ebke/widelands/ping-on-pause
Widelands Developers: Pending requested
Diff: 15 lines (+3/-2)
1 file modified
src/network/nethost.cc (+3/-2)
Revision history for this message
Nasenbaer (nasenbaer) wrote :

Oh you are right, haven't thought about the "normal" case, when implementing the forcedPause fix :-D
Thank you for the patch!

Changed in widelands:
status: New → Confirmed
milestone: none → build18-rc1
Revision history for this message
Shevonar (shevonar) wrote :

When you think your fix is complete you should propose your branch for merging ;) I could do it for you, but you have to know when you are ready.

Revision history for this message
Shevonar (shevonar) wrote :

The branch was merged in revision 6421, so I am setting this to "Fix Committed".

Changed in widelands:
status: Confirmed → Fix Committed
importance: Undecided → Medium
Revision history for this message
SirVer (sirver) wrote :

Released in build-18 rc1.

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.