Start using C++11 features in Widelands sources
Bug #1005955 reported by
SirVer
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Wishlist
|
Unassigned |
Bug Description
I am eager to use some of the new C++11 features in Widelands. But before I leap, I wanted to discuss this here: What is the situation for maintainers/other developers. Has everybody access to a modern compiler or will we need to wait another year or two?
Related branches
lp:~widelands-dev/widelands/cxx11
- Tino: Approve
- Widelands Developers: Pending requested
-
Diff: 714 lines (+75/-135)32 files modifiedCMakeLists.txt (+29/-2)
src/compile_assert.h (+0/-28)
src/economy/fleet.cc (+1/-1)
src/economy/portdock.cc (+1/-1)
src/graphic/animation_gfx.cc (+1/-1)
src/graphic/render/gamerenderer_gl.cc (+2/-2)
src/graphic/text/rt_render.cc (+1/-1)
src/io/bitinbuffer.h (+1/-3)
src/io/bitoutbuffer.h (+1/-3)
src/io/filesystem/disk_filesystem.cc (+1/-4)
src/log.h (+1/-1)
src/logic/constructionsite.cc (+1/-1)
src/logic/dismantlesite.cc (+1/-1)
src/logic/field.h (+5/-6)
src/logic/game.cc (+2/-2)
src/logic/ship.cc (+2/-2)
src/logic/trainingsite.cc (+2/-0)
src/logic/warehouse.cc (+1/-1)
src/logic/widelands_geometry.h (+1/-3)
src/map_io/widelands_map_buildingdata_data_packet.cc (+4/-4)
src/map_io/widelands_map_exploration_data_packet.cc (+2/-2)
src/minizip/unzip.cc (+0/-8)
src/scripting/pluto.cc (+1/-1)
src/type_check.h (+0/-33)
src/ui_basic/checkbox.cc (+2/-4)
src/ui_basic/listselect.h (+0/-1)
src/ui_basic/table.h (+1/-2)
src/ui_basic/tabpanel.cc (+2/-4)
src/ui_basic/window.cc (+4/-6)
src/vector.h (+0/-2)
src/wlapplication.cc (+4/-2)
src/wui/encyclopedia_window.cc (+1/-3)
Changed in widelands: | |
importance: | Undecided → Wishlist |
status: | New → Incomplete |
milestone: | none → build18-rc1 |
Changed in widelands: | |
milestone: | build18-rc1 → none |
To post a comment you must log in.
Are there some specific feature you want to use? What do you think they will improve?
In general I do not mind to use some c++11 features, if they improve the code (e.g.: readability, maintainability). But I am against forcing a newer compiler, if c++11 feature should only be used, because we can.
I have found a nice list which g++ version is required for which feature: http:// gcc.gnu. org/projects/ cxx0x.html
As you can see the first features are supported by g++ 4.3, others only by the latest version (4.7), or none at all.
Also I think the hint on this list is important that c++11 is still experimental. What if widelands gets broken, because the c++11 implementation was changed?
----
My system:
Ubuntu 12.04
g++ 4.6.3