The css-files contain invalid css
Bug #736975 reported by
Hans Joachim Desserud
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Widelands Website |
Fix Released
|
Low
|
Shevonar | ||
Bug Description
I recently discovered some of the css-files does not contain valid css. Attempting to validate the files currently results in five errors and 24 warnings. I have pushed a branch (https:/
.box_item_model .border_top {
border-top: 1px solid rgb(9, 9, );
}
where it fails to parse the value, since it is missing the last color value. I did not change this, as I wasn't sure what the intended color was.
The warnings mainly concern colors which are used in multiple contexts, which I have also left alone, since I was unsure what the correct fix would be.
Ideally the warnings should be fixed as well, but I would be happy if the remaining error is fixed so that the css validates.
--
The quickest way to check if the css is valid is to go to the directory widelands-
To combine all the .css-files, run the following command
cat * > all.css
and then upload the file you wrote to.
Related branches
lp:~hjd/widelands-website/valid-css
- Widelands Developers: Pending requested
-
Diff: 68 lines (+5/-6)4 files modifiedmedia/css/base.css (+3/-3)
media/css/forum.css (+1/-1)
media/css/messages.css (+0/-1)
media/css/old_xoops_remainings.css (+1/-1)
lp:~widelands-dev/widelands-website/new-design
- SirVer: Approve
-
Diff: 12732 lines (+6274/-4358)146 files modifiedREADME.txt (+15/-0)
local_settings.py.sample (+1/-1)
media/css/base.css (+349/-354)
media/css/base_ielt8.css (+3/-0)
media/css/base_ielt9.css (+9/-0)
media/css/comments.css (+28/-23)
media/css/documentation.css (+85/-0)
media/css/forum.css (+86/-109)
media/css/help.css (+25/-0)
media/css/maps.css (+27/-26)
media/css/messages.css (+34/-72)
media/css/modal_windows.css (+0/-35)
media/css/navigation.css (+109/-58)
media/css/news.css (+0/-68)
media/css/notice.css (+29/-11)
media/css/old_xoops_remainings.css (+0/-318)
media/css/profile.css (+3/-11)
media/css/screens.css (+2/-17)
media/css/search.css (+0/-22)
media/css/wiki.css (+38/-77)
media/fancybox/helpers/jquery.fancybox-buttons.css (+85/-0)
media/fancybox/helpers/jquery.fancybox-buttons.js (+115/-0)
media/fancybox/helpers/jquery.fancybox-media.js (+85/-0)
media/fancybox/helpers/jquery.fancybox-thumbs.css (+54/-0)
media/fancybox/helpers/jquery.fancybox-thumbs.js (+157/-0)
media/fancybox/jquery.fancybox.css (+234/-0)
media/fancybox/jquery.fancybox.js (+1463/-0)
media/fancybox/jquery.fancybox.pack.js (+35/-0)
media/js/scripts.js (+15/-0)
online_help/templates/inlines/display_building.html (+0/-232)
online_help/templates/inlines/display_ware.html (+0/-10)
online_help/templates/inlines/display_worker.html (+0/-10)
pybb/forms.py (+6/-3)
pybb/templatetags/pybb_extras.py (+1/-1)
pybb/urls.py (+1/-1)
pybb/util.py (+2/-2)
pybb/views.py (+4/-14)
settings.py (+45/-12)
templates/404.html (+10/-6)
templates/500.html (+11/-6)
templates/base.html (+56/-119)
templates/django_messages/base.html (+20/-2)
templates/django_messages/compose.html (+16/-25)
templates/django_messages/inbox.html (+34/-22)
templates/django_messages/outbox.html (+30/-22)
templates/django_messages/trash.html (+39/-31)
templates/django_messages/view.html (+26/-46)
templates/footer.html (+5/-5)
templates/login_box.html (+68/-0)
templates/mainpage.html (+20/-46)
templates/mainpage/changelog.html (+5/-5)
templates/mainpage/developers.html (+5/-5)
templates/mainpage/online_users.html (+14/-8)
templates/navigation.html (+76/-72)
templates/news/base_news.html (+1/-5)
templates/news/inlines/post_detail.html (+19/-49)
templates/news/post_archive_month.html (+27/-25)
templates/news/post_archive_year.html (+29/-30)
templates/news/post_detail.html (+20/-20)
templates/news/post_list.html (+26/-26)
templates/notification/base.html (+5/-0)
templates/notification/messages_received/notice.html (+2/-1)
templates/notification/messages_replied/notice.html (+2/-1)
templates/notification/messages_reply_received/notice.html (+2/-1)
templates/notification/messages_sent/notice.html (+3/-2)
templates/notification/notices.html (+73/-102)
templates/notification/single.html (+30/-40)
templates/pybb/add_post.html (+79/-6)
templates/pybb/category.html (+19/-0)
templates/pybb/delete_post.html (+16/-17)
templates/pybb/edit_post.html (+53/-7)
templates/pybb/forum.html (+72/-75)
templates/pybb/index.html (+17/-9)
templates/pybb/inlines/add_post_form.html (+56/-51)
templates/pybb/inlines/display_category.html (+39/-18)
templates/pybb/last_posts.html (+15/-8)
templates/pybb/topic.html (+284/-76)
templates/registration/activate.html (+15/-3)
templates/registration/activation_complete.html (+12/-8)
templates/registration/login.html (+33/-46)
templates/registration/password_change_done.html (+8/-16)
templates/registration/password_change_form.html (+47/-59)
templates/registration/password_reset_complete.html (+8/-16)
templates/registration/password_reset_confirm.html (+39/-30)
templates/registration/password_reset_done.html (+8/-16)
templates/registration/password_reset_form.html (+20/-30)
templates/registration/registration_complete.html (+6/-14)
templates/registration/registration_form.html (+52/-80)
templates/right_boxes.html (+96/-126)
templates/sphinxdoc/app_list.html (+13/-9)
templates/sphinxdoc/base.html (+2/-1)
templates/sphinxdoc/documentation.html (+53/-58)
templates/threadedcomments/inlines/comments.html (+46/-58)
templates/threadedcomments/inlines/reply_to.js (+41/-33)
templates/threadedcomments/preview_comment.html (+20/-23)
templates/wiki/base.html (+2/-1)
templates/wiki/changeset.html (+21/-20)
templates/wiki/edit.html (+109/-124)
templates/wiki/history.html (+48/-52)
templates/wiki/index.html (+3/-4)
templates/wiki/view.html (+27/-26)
templates/wlggz/edit_ggz.html (+20/-38)
templates/wlhelp/base.html (+10/-0)
templates/wlhelp/building_details.html (+57/-11)
templates/wlhelp/buildings.html (+71/-68)
templates/wlhelp/index.html (+22/-0)
templates/wlhelp/inlines/display_buildings.html (+49/-0)
templates/wlhelp/tribe_details.html (+26/-0)
templates/wlhelp/ware_details.html (+21/-12)
templates/wlhelp/wares.html (+30/-14)
templates/wlhelp/worker_details.html (+18/-11)
templates/wlhelp/workers.html (+30/-14)
templates/wlmaps/base.html (+1/-1)
templates/wlmaps/index.html (+56/-164)
templates/wlmaps/map_detail.html (+78/-41)
templates/wlmaps/upload.html (+21/-0)
templates/wlpoll/base.html (+2/-0)
templates/wlpoll/poll_detail.html (+20/-38)
templates/wlpoll/poll_list.html (+18/-13)
templates/wlprofile/base.html (+1/-1)
templates/wlprofile/edit_profile.html (+50/-72)
templates/wlprofile/view_profile.html (+71/-71)
templates/wlscreens/base.html (+0/-1)
templates/wlscreens/index.html (+40/-158)
templates/wlsearch/search.html (+100/-94)
templates/wlwebchat/index.html (+19/-24)
urls.py (+5/-4)
widelandslib/tribe.py (+14/-14)
wiki/views.py (+3/-2)
wlggz/forms.py (+1/-1)
wlhelp/management/commands/update_help.py (+16/-4)
wlhelp/management/commands/update_help_pdf.py (+11/-1)
wlhelp/models.py (+8/-1)
wlhelp/urls.py (+11/-8)
wlhelp/views.py (+38/-14)
wlmaps/forms.py (+63/-5)
wlmaps/models.py (+12/-17)
wlmaps/templatetags/wlmaps_extra.py (+14/-0)
wlmaps/views.py (+24/-88)
wlprofile/fields.py (+11/-6)
wlprofile/forms.py (+3/-5)
wlprofile/models.py (+3/-3)
wlprofile/templatetags/custom_date.py (+4/-3)
wlprofile/views.py (+0/-3)
wlrecaptcha/forms.py (+3/-3)
wlsearch/views.py (+1/-1)
| Changed in widelands-website: | |
| importance: | Undecided → Low |
| tags: | added: validation |
Revision history for this message
| SirVer (sirver) wrote | #1 |
| Changed in widelands-website: | |
| status: | New → Confirmed |
Revision history for this message
| Hans Joachim Desserud (hjd) wrote | #2 |
| Changed in widelands-website: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Shevonar (shevonar) |
Revision history for this message
| Hans Joachim Desserud (hjd) wrote | #3 |
Revision history for this message
| Shevonar (shevonar) wrote | #4 |
| Changed in widelands-website: | |
| status: | In Progress → Fix Committed |
| Changed in widelands-website: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hans Joachim, thanks for reporting this. I would appreciate it if you would make suggestions for the colors following your own convenience and try to fix the remaining warnings. There is noone working on the homepage layout and design and therefore you have absolute freedom.
Please reply here if you are willing to invest into this, otherwise I will go ahead and merge your branch as is.