Text truncation in encyclopedia

Bug #1759376 reported by GunChleoc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Widelands Website
Fix Released
Undecided
kaputtnik

Bug Description

On this page:

https://wl.widelands.org/encyclopedia/atlanteans/workers/

The "Armorsmith" shows up as "Armorsm", because the first column isn't wide enough. Wares have the same problem.

I'm on Firefox with 800px screen width.

Revision history for this message
kaputtnik (franku) wrote :

This was introduced with the "show scripting name" branch. I will try to find a better style.

Changed in widelands-website:
status: New → Confirmed
assignee: nobody → kaputtnik (franku)
Revision history for this message
kaputtnik (franku) wrote :

I have changed the width of some columns on the productive site. Can you please check again?

https://wl.widelands.org/encyclopedia/atlanteans/workers/

I would also suggest to change the look of the buildings tables: Instead showing the number of images for 'Build cost' and 'Stores' i think it would be better to show only one image with the number as a string. E.g. for the Atlanteans Scouts house: '1 x OneImageOfGranite <br /> 2 x OneImageOfLogs' and '4 x OneImageOfGold'

That would prevent counting the images manually, if one wants to know the number of build cost.

Revision history for this message
kaputtnik (franku) wrote :

The Frisians tribe is currently missing on the webpage. Should i update the package on the server to have the frisians in the Encyclopedia?

Revision history for this message
GunChleoc (gunchleoc) wrote :

+1 to #2 and #3.

Column width looks good now :)

Revision history for this message
kaputtnik (franku) wrote :

All done :-)

Changed in widelands-website:
status: Confirmed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

I went through the Atlanteans again, the Weaponsmith is missing half of the final h, both in the workers and the wares tables. We can be generous about losing space for the middle column, because we won't add any vertical space by it due to the new detailed info on the right.

Changed in widelands-website:
status: Fix Released → Confirmed
Revision history for this message
kaputtnik (franku) wrote :

The middle column is already calculated by the browser.

The reason why i give some columns a specific width is the buildings view: I found it disturbing the each table (headquarters, small, middle, ...) had different width for the columns.

The attached branch has now also the amount of wares related to 'Build cost' and 'Stores' as a string.

Revision history for this message
GunChleoc (gunchleoc) wrote :

Screenshot looks good :)

I agree that the column width should be consistent.

Revision history for this message
kaputtnik (franku) wrote :

I have merged the branch on the productive site. Can you please check again? You may have to refresh the browsers cache (STRG +F5).

If you think it is fine, i will commit then.

Revision history for this message
GunChleoc (gunchleoc) wrote :

All OK now, thanks! :)

Revision history for this message
kaputtnik (franku) wrote :

Thanks :-)

Changed in widelands-website:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.