notification to user of user's posts

[Albert Einstein]

When you subscribe any forum topic and replay it, you will receive e-mail notification. It is not necessary, while you know that you have written something there.

[kaputtnik (franku)]

Yes, from time to time i think about this behavior. Sometimes i think receiving a mail containing my own post is superfluous, sometimes not. I din't come to a conclusion yet... so some more meanings will be helpful :-)

Other meanings?

I don't like the form of those emails anyway. E.g. the Subject should be something like "[A new topic | A new Post | An new map] was added to widelands.org", and the stupid sentence "You have received the following notice..." can be omitted. Especially quoting should be more visible for forum posts.

[GunChleoc (gunchleoc)]

I think for your own posts, it's superfluous. Nobody else does it. The interesting bit will be the first reply by somebody else to your own reply.

I agree about the e-mail subjects, that would be a great feature.

[kaputtnik (franku)]

All done right now. I am unsure how to serve forum emails:

1. Using post.body: The content is send as written, e.g. with all markdown syntax. Quoting should work fine with this setting, because usual email programs knows how to handle the quote sign '> '. At least the email programs i used :-) But, e.g. images were shown only with markdown syntax.

2. Using post.body_html: The html version of the text. Using this means email get send as an html message. AFAIK html messages should not be used because of security reasons. On the other side they have a nice formatting. How they display on the users screen depends on the settings in their email programs.

[GunChleoc (gunchleoc)]

I am all for plain-text messages. HTML messages are a security risk - I don't know how secure Django is in this respect and whether scripts could be injected that way. Better safe than sorry.

[kaputtnik (franku)]

> Better safe than sorry.

I second that :-)

The code uses now the 'description' of a notification, that is the second row for each notification in https://wl.widelands.org/notification/ . So this could be edited with less effort in the admin page. Optionally one can make a template called 'short.txt' to get a custom subject.

While i am on it, i currently looking forward to fix bug 340920, and try to provide useful diff...

[GunChleoc (gunchleoc)]

I think "[Widelands.org] Forum New Post" etc. would be perfect for the title, and "a new comment has been posted to a topic you observe" etc. as the first information line for the message body.

[kaputtnik (franku)]

> I think "[Widelands.org] Forum New Post" etc. would be perfect for the title,

Showing the nofication.display name is done for the subject. Is '[widelands.org]' really needed since we have '<email address hidden>' as the sender?

> and "a new comment has been posted to a topic you observe" etc. as the first information line for the message body.

It would be nice to have the topics name in there, so the mail content is:

"A new forum post was added to the topic "{{ topic }}":

"{{ user }}" wrote:

{{ post.body }}

We can discuss this when the merge proposal is open.

[GunChleoc (gunchleoc)]

Sounds good to me :)