messages from django messages framework are shown in wiki page

[kaputtnik]

This was introduced with http://bazaar.launchpad.net/~widelands-dev/widelands-website/trunk/revision/447

Steps to reproduce:

1. Go to https://wl.widelands.org/messages/inbox/
2. Delete a message
3. Go to https://wl.widelands.org/wiki/Main%20Page/

Result: The message "Message successfully deleted." is shown then.

We have to check all other apps, if they use the django messages framework.

[kaputtnik (franku)]

The bug is fixed in the linked branch and i couldn't find any other app that triggers this behavior.

While i am on it, is there a need for more such messages that appear if something went ok?
In wiki there were some messages, but they weren't shown because some code in the template was missing:

"The article was created successfully"
"The article was edited successfully"
"The article was reverted successfully"

I removed them in the last branch, because they are not shown and nobody complained. Should i implement those again?

I think in other places such messages aren't needed? Any other suggestions?

[GunChleoc (gunchleoc)]

I haven't done anything int he wiki for a bit. I think anything that clearly changes the current page doesn't need a message, unless there's an error.

[kaputtnik (franku)]

I second that

Will merge this small fix directly then.

[GunChleoc (gunchleoc)]

+1 - code LGTM too.