Cleanup notification_notice
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Widelands Website |
Fix Released
|
Medium
|
kaputtnik |
Bug Description
The database is 'spammed' with notices from notification. I've made some query's:
select count(*) from notification_
+----------+
| count(*) |
+----------+
| 6973731 |
+----------+
There are overall over 6 millions notices stored in the database. A comparison to pybb_post and pybb_topic:
pybb_post: 17375
pybb_topic: 1873
Accessing the notifications page (http://
On IRC we talked about it and the suggestion was to remove the notice list in the view as first step and wait until someone complains about it. If not we should omit creating of such notices.
I totally agree on that suggestion. But first i want to to delete the amount of notices, just to speed up accessing the notifications page by deleting all notices added before 1.1.2016. Are you ok with that?
In the end we may have notices only for setting the e-mails about the things a user want to be noticed and no list of notices anymore. I am fine with that. If someone complains about this, we could make a django command to delete all notices older than 1 year or so.
Any other suggestions?
Related branches
- SirVer: Approve
-
Diff: 1740 lines (+255/-1078)42 files modifiedmedia/css/notice.css (+0/-1)
news/migrations/0002_auto_20170417_1857.py (+19/-0)
notification/README (+6/-1)
notification/admin.py (+16/-10)
notification/atomformat.py (+0/-551)
notification/context_processors.py (+0/-10)
notification/decorators.py (+0/-65)
notification/engine.py (+4/-1)
notification/feeds.py (+0/-75)
notification/management/commands/emit_notices.py (+2/-1)
notification/migrations/0002_auto_20170417_1857.py (+25/-0)
notification/models.py (+87/-133)
notification/urls.py (+2/-5)
notification/views.py (+16/-81)
pybb/admin.py (+7/-6)
pybb/forms.py (+4/-6)
pybb/management/pybb_notifications.py (+2/-0)
templates/notification/email_body.txt (+2/-2)
templates/notification/forum_new_post/notice.html (+0/-5)
templates/notification/forum_new_topic/notice.html (+0/-4)
templates/notification/full.html (+0/-1)
templates/notification/maps_new_map/full.txt (+7/-0)
templates/notification/messages_deleted/full.txt (+0/-1)
templates/notification/messages_deleted/notice.html (+0/-1)
templates/notification/messages_received/notice.html (+0/-3)
templates/notification/messages_recovered/full.txt (+0/-1)
templates/notification/messages_recovered/notice.html (+0/-1)
templates/notification/messages_replied/full.txt (+0/-1)
templates/notification/messages_replied/notice.html (+0/-3)
templates/notification/messages_reply_received/notice.html (+0/-3)
templates/notification/messages_sent/full.txt (+0/-1)
templates/notification/messages_sent/notice.html (+0/-3)
templates/notification/notice.html (+0/-1)
templates/notification/notice_settings.html (+20/-50)
templates/notification/single.html (+0/-40)
templates/notification/wiki_article_edited/notice.html (+0/-4)
templates/notification/wiki_observed_article_changed/notice.html (+0/-1)
templates/notification/wiki_revision_reverted/notice.html (+0/-2)
wiki/forms.py (+7/-0)
wiki/management.py (+2/-3)
wlmaps/management.py (+18/-0)
wlmaps/models.py (+9/-1)
Changed in widelands-website: | |
importance: | Undecided → Medium |
Changed in widelands-website: | |
status: | New → Triaged |
Changed in widelands-website: | |
assignee: | nobody → kaputtnik (franku) |
Changed in widelands-website: | |
status: | Triaged → Won't Fix |
status: | Won't Fix → In Progress |
Changed in widelands-website: | |
status: | In Progress → Fix Released |
Sounds good to me.