Map uploading is broken as minimaps can no longer be generated

Bug #1336137 reported by SirVer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Widelands Website
Fix Released
Critical
Shevonar
widelands
Fix Released
Critical
Unassigned

Bug Description

Since the one world merger, minimaps can not be generated anymore. uploading new maps to the site is now impossible.

Traceback (most recent call last):

 File "/var/www/django_projects/wlwebsite/lib/python2.7/site-packages/django/core/handlers/base.py", line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/var/www/django_projects/wlwebsite/lib/python2.7/site-packages/django/contrib/auth/decorators.py", line 23, in _wrapped_view
   return view_func(request, *args, **kwargs)

 File "/var/www/django_projects/wlwebsite/code/widelands/wlmaps/views.py", line 93, in upload
   if form.is_valid():

 File "/var/www/django_projects/wlwebsite/lib/python2.7/site-packages/django/forms/forms.py", line 121, in is_valid
   return self.is_bound and not bool(self.errors)

 File "/var/www/django_projects/wlwebsite/lib/python2.7/site-packages/django/forms/forms.py", line 112, in _get_errors
   self.full_clean()

 File "/var/www/django_projects/wlwebsite/lib/python2.7/site-packages/django/forms/forms.py", line 268, in full_clean
   self._clean_form()

 File "/var/www/django_projects/wlwebsite/lib/python2.7/site-packages/django/forms/forms.py", line 296, in _clean_form
   self.cleaned_data = self.clean()

 File "/var/www/django_projects/wlwebsite/code/widelands/wlmaps/forms.py", line 42, in clean
   minimap = wlmap.make_minimap(WIDELANDS_SVN_DIR)

 File "/var/www/django_projects/wlwebsite/code/widelands/widelandslib/map.py", line 244, in make_minimap
   i = Image.open(datadir + '/worlds/' + self._world_name + '/pics/' + t.name + '_00.png').convert("RGB")

 File "/var/www/django_projects/wlwebsite/lib/python2.7/site-packages/PIL/Image.py", line 1974, in open
   fp = builtins.open(fp, "rb")

IOError: [Errno 2] No such file or directory: '/var/loaded_repositories/widelands_trunk//worlds/blackland/pics/ashes_00.png'

Related branches

SirVer (sirver)
Changed in widelands:
status: New → Confirmed
importance: Undecided → Critical
Changed in widelands-website:
importance: High → Critical
Changed in widelands:
milestone: none → build19-rc1
Revision history for this message
SirVer (sirver) wrote :

Shevonar, do you think you can look into that?

Changed in widelands-website:
assignee: nobody → Shevonar (shevonar)
Revision history for this message
Shevonar (shevonar) wrote :

I might be able to take a look at this this weekend. I will see how i can incorporate your map_info library.

Revision history for this message
SirVer (sirver) wrote :

That would be awesome!!! I would like to work on it too, but I am traveling and I do not think I will have much time.

If you do, please also add a warning for new maps (the map_info.cc binary outputs an empty world name for new maps) that they only work with dev versions and b19 or later (or rather: requires Widelands > b18 or so, so that we do not need to change it again in the future).

Also, I go to the IRC channel if I work on Widelands. we can meet and coordinate there, so that we do not do double work. If I am not in the IRC, I am not working on the issue.

Revision history for this message
SirVer (sirver) wrote :

Thanks for taking care of this Shevonar. Quality work, as usual.

Changed in widelands-website:
status: Confirmed → Fix Released
Changed in widelands:
status: Confirmed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.