Map section: upload fails if Widelands internal map name already exists
Bug #1210606 reported by
Nasenbaer
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Widelands Website |
Fix Released
|
Medium
|
Shevonar | ||
Bug Description
If you try to upload e.g. the map "XYZ" and there is already a map with said name (does not matter what the file name is or whether the two maps are identical or differ) the uploader will just behave as if no map was selected.
Either it should bail out, that there was an error and that there may not be two different maps with the same name (name uniqueness) or it should upload it and add a suffix (e.g. "XYZ [2]")
Related branches
lp:~widelands-dev/widelands-website/map-uploader-fixes
- SirVer: Approve
-
Diff: 65 lines (+12/-13)3 files modifiedtemplates/wlmaps/index.html (+3/-0)
templates/wlmaps/upload.html (+6/-0)
wlmaps/views.py (+3/-13)
| Changed in widelands-website: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
Revision history for this message
| Shevonar (shevonar) wrote | #1 |
| Changed in widelands-website: | |
| assignee: | nobody → Shevonar (shevonar) |
Revision history for this message
| Shevonar (shevonar) wrote | #2 |
| Changed in widelands-website: | |
| status: | Confirmed → In Progress |
| Changed in widelands-website: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
There is a check for the map name in the code and it should throw an error on map upload. I guess this error somehow does not show up and the upload fails silently. I am investigating.