Incompatible with new output of net-tools

[Hanno Böck]

Latest wicd beta release (1.7.1 beta2) fails to work with the latest code of net-tools (Gentoo ships a snapshot of the net-tools git code from 20111120). They've changed the output of tools like ifconfig.

See this Gentoo bug for info:
https://bugs.gentoo.org/show_bug.cgi?id=391451

[David Paleino (dpaleino)]

Hello Hanno,

On Wed, 23 Nov 2011 11:54:13 -0000, Hanno Böck wrote:

> Latest wicd beta release (1.7.1 beta2) fails to work with the latest
> code of net-tools (Gentoo ships a snapshot of the net-tools git code
> from 20111120). They've changed the output of tools like ifconfig.
>
> See this Gentoo bug for info:
> https://bugs.gentoo.org/show_bug.cgi?id=391451

What's the new output of ifconfig? Could you please provide an example?

Also, I fixed something similar in rev:631, would you please check if that is
what you're looking for?

http://bazaar.launchpad.net/~wicd-devel/wicd/experimental/revision/631

Thank you,
David

--
 . ''`. Debian developer | http://wiki.debian.org/DavidPaleino
 : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'` GPG: 1392B174 ----|---- http://deb.li/dapal
   `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

[Hanno Böck (hanno-hboeck)]

Output attached. I tried to test your patch, but it seems it doesn't apply to the latest wicd beta release. I'll try a bazaar-snapshot later.

[David Paleino (dpaleino)]

On Wed, 23 Nov 2011 17:53:40 -0000, Hanno Böck wrote:

> Output attached. I tried to test your patch, but it seems it doesn't
> apply to the latest wicd beta release. I'll try a bazaar-snapshot later.

The output you attached seems the one that patch is meant for, i.e. see also
https://github.com/cbxbiker61/wicd/commit/b58c0409e89b72ff95b87316faf5b8191350ed9e .

It would be nice if you could test it though :)

Thanks,
David

--
 . ''`. Debian developer | http://wiki.debian.org/DavidPaleino
 : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'` GPG: 1392B174 ----|---- http://deb.li/dapal
   `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

[Hanno Böck (hanno-hboeck)]

Tested git-code, it works fine.

Could you make a new wicd release or beta-release based on the current
code?

[David Paleino (dpaleino)]

On Thu, 24 Nov 2011 12:16:39 -0000, Hanno Böck wrote:

> Tested git-code, it works fine.
>
> Could you make a new wicd release or beta-release based on the current
> code?
>

The 1.7.1 release is planned on 17-18 december, but I hope I can make a b3
release before that date.

--
 . ''`. Debian developer | http://wiki.debian.org/DavidPaleino
 : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'` GPG: 1392B174 ----|---- http://deb.li/dapal
   `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

[Jason Kim (c-jason-kim)]

I'm still seeing an issue with updated code. Running Gentoo, affected by the original issue.

Problem seems to be in wnettools.py on line 731. Should be changed:
         # check multiple ifconfig output styles
         for pat in [ip_pattern, ip_pattern1]:
- m = misc.RunRegex(ip_pattern, output)
+ m = misc.RunRegex(pat, output)
             if m: return m
         return None

Thanks,
-JayKim

[David Paleino (dpaleino)]

On Thu, 24 Nov 2011 16:21:13 -0000, Jason Kim wrote:

> I'm still seeing an issue with updated code. Running Gentoo, affected by
> the original issue.
>
> Problem seems to be in wnettools.py on line 731. Should be changed:
> # check multiple ifconfig output styles
> for pat in [ip_pattern, ip_pattern1]:
> - m = misc.RunRegex(ip_pattern, output)
> + m = misc.RunRegex(pat, output)
> if m: return m
> return None

Oops, silly bug.
Fixed in rev. 651, thanks.

David

--
 . ''`. Debian developer | http://wiki.debian.org/DavidPaleino
 : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'` GPG: 1392B174 ----|---- http://deb.li/dapal
   `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

[David Paleino (dpaleino)]

Released with 1.7.1, closing.