should put OOPS ID / URL in .uploaded file
Bug #1582470 reported by
Selene ToyKeeper
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Whoopsie |
Fix Released
|
Undecided
|
Brian Murray | ||
whoopsie (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
To make it easier to investigate crash dumps, it would be helpful if whoopsie could put the OOPS ID and errors.ubuntu.com URL in the .uploaded file it creates after upload to indicate successful transfer.
This makes it much easier, for example, for a script to pull everything in /var/crash/ and get information relevant for submitting a bug report. At the moment, I instead try to parse the ID out of whoopsie.log and generate the URL, but that tends to be a bit brittle.
This is mostly to help with data collection during automated testing, but also to make manual investigations easier.
Related branches
lp:~toykeeper/whoopsie/uploaded-url
- Brian Murray (community): Disapprove
-
Diff: 156 lines (+34/-7)6 files modifiedsrc/monitor.c (+2/-2)
src/tests/test_utils.c (+1/-1)
src/utils.c (+5/-1)
src/utils.h (+1/-1)
src/whoopsie.c (+24/-2)
src/whoopsie.h (+1/-0)
Changed in whoopsie: | |
status: | New → In Progress |
assignee: | nobody → Brian Murray (brian-murray) |
Changed in whoopsie: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
Looking through the code, it looks like this might require handle_response() to store the OOPS ID somewhere, so that parse_and_ upload_ report can access it (maybe), so that it could be accessed inside of process_ existing_ files() , so that it can be passed to mark_handled(), to make the data available when it creates the uploaded_file.
C isn't very amenable to returning multiple values, which makes it more awkward to pass this data back through a couple levels of nesting. Some sort of "last_oops_id" global would be fairly easy, but messy. Not really happy with either one, but I think I'll try the latter for now.