indi_mainimage displayed above header_accordion

Bug #930090 reported by HRN
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
webtrees
Fix Released
Low
Unassigned

Bug Description

Just a small annoying bug in both stable and svn
In Google Chrome (17.0.963.46 m) the indi_mainimage is displayed above header_accordion.
Correctly aligned when reloading the page or closing/opening the sidebar.
Looks fine in FF and IE

Revision history for this message
HRN (hhrrnn) wrote :
Revision history for this message
kiwi (kiwi3685-deactivatedaccount) wrote :

Yes, you are right. The problem is it is an intermittent bug I have found hard to reliably reproduce, which makes tracing the cause difficult.

Changed in webtrees:
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → kiwi (kiwi3685)
Revision history for this message
kiwi (kiwi3685-deactivatedaccount) wrote :

@HRN Could you try something for me?

In the file webtrees/individual.php reverse the order of lines 183, 184, so they change from:

 adjHeader();
 jQuery("#main").css("visibility", "visible");

to:

 jQuery("#main").css("visibility", "visible");
 adjHeader();

I've tried this and it "seems" to fix the problem. But because it doesn't always happen, I can't be sure.

Revision history for this message
HRN (hhrrnn) wrote :

It seems better, but doesn't fix the problem completely.

Revision history for this message
kiwi (kiwi3685-deactivatedaccount) wrote :

OK, thanks.

There are other changes that need to done to the javascript on this page, so I will look at it once 1.2.7 is released (in the next couple of days).

Changed in webtrees:
status: Confirmed → In Progress
Revision history for this message
kiwi (kiwi3685-deactivatedaccount) wrote :

@HRN - can you try this complete replacement for individual.php and let me know if it fixes the problem.

Revision history for this message
HRN (hhrrnn) wrote :

Again, it doesn't seem to fix the problem completely.
Clicking through dozens of indis, it seems less frequent, but it's hard to find a pattern of the occurrence

Revision history for this message
HRN (hhrrnn) wrote :

It occures to me, that it "always" happens to the first indi chosen from the sidepanel. Going to a son or a daughter in a family, the thumb is displayed on top of the accordion. Then, choosing any siblings from the sidepanel , it looks fine.
Jumping up or down a generation, choosing a new son or daughter, the bug occures again....

Revision history for this message
kiwi (kiwi3685-deactivatedaccount) wrote :

<<It occures to me, that it "always" happens to the first indi chosen from the sidepanel.>>
That's interesting, thanks. At least it points to another place to look.

Revision history for this message
kiwi (kiwi3685-deactivatedaccount) wrote :

I've had another attempt - svn 13572. let me know if its any better.

Revision history for this message
HRN (hhrrnn) wrote :

Sorry, it doesn't seem to fix the problem.
For what it's worth, this never happens when there is a thumbnail, only when siluetts are displayed.

Revision history for this message
kiwi (kiwi3685-deactivatedaccount) wrote :

Interesting. What size are you thumbnails set to be in config pages?

Revision history for this message
HRN (hhrrnn) wrote :

100px

Revision history for this message
kiwi (kiwi3685-deactivatedaccount) wrote :

<<100px>>
Same as mine.

The silhouette images are 99px wide. I wonder if 1px could make the difference? Try svn 13574. I have temporarily set min-width for the image container to 100px.

Revision history for this message
HRN (hhrrnn) wrote :

Looks like 1px made the difference. Changes in revision 12124 made the problem disappear completely.
Thanks a lot

Revision history for this message
kiwi (kiwi3685-deactivatedaccount) wrote :

Great. That was just a temporary fix to test the theory. Now I need to find a fix that works any thumbnail size, and also allows for situations where there is no thumbnail and no silhouette, as all are config options. I think I see the solution though.

Revision history for this message
kiwi (kiwi3685-deactivatedaccount) wrote :

Final (I hope) fixe in SVN 13577

Changed in webtrees:
status: In Progress → Fix Committed
Revision history for this message
fisharebest (fisharebest) wrote :

Fix released in 1.3.0

Changed in webtrees:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.