GEDFact_assistant - relationship names not localised

[Muadh Hamidaddin]

$parentlinks and $spouselinks in
\modules_v3\GEDFact_assistant\_CENS\census_3_search_add.php
 and
 \modules_v3\GEDFact_assistant\_MEDIA\media_1_ctrl.php
are not translated as evident in Family navigator.

[fisharebest (fisharebest)]

This is very bad.

Not only are relationship names hard-coded into English, the code has hard-coded internal variables in English, that are actually translated. e.g.

if ($currpid=="Wife" || $currpid=="Husband") {
 $parentlinks .= "'Father in Law',"; // label = 1st Gen Male Relationship
} else {
 $parentlinks .= "'Grand-Father',"; // label = 2st Gen Male Relationship
}

So, the variable $currpid isn't set to "Wife" or "Husband", but to the *translated* name of that relationship. Hence when you change language, the "father-in-law" relationship is actually displayed as "grandfather".

[kiwi (kiwi3685-deactivatedaccount)]

These were all written for PGV. It looks like they have never been upgraded. Is it practical to replace all these relationships with their WT_I18N equivalent's, or does the whole structure need re-writing? I could do the former, but not keen to tackle the latter :-(

[Muadh Hamidaddin (muadhh)]

I hope I am not making trouble here!

[fisharebest (fisharebest)]

<<Is it practical to replace all these relationships with their WT_I18N equivalent's, or does the whole structure need re-writing?>>

You would need to refactor the code so that it generates relationship names from our internal "fatmotbro" strings.

This could be as simple as updating the $currpid variable, although there could be more. I stopped looking at that point....

[fisharebest (fisharebest)]

<<I hope I am not making trouble here!>>

Not at all!

This module currently works only for UK and US censuses. We will need to fix this bug before we can extend it to work with censuses from other countries.