XHTML validation errors in webtrees theme header

Bug #802351 reported by lindon on 2011-06-27
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
webtrees
Fix Released
Low
Unassigned

Bug Description

Fix validation errors noted at http://validator.w3.org/check.

lindon (ycm05) wrote :

What is the actual validation error here? Wrapping a simple text element like ' | ' in <li></li> tags seems like overkill to me. If it's correct then other themes, especially fab will need to change as well.

fisharebest (fisharebest) wrote :

The error is that a "<ul>" may only contain "<li></li>"

Here, it contains a mixture of "<li></li>" and " | ".

So, the patch (if I read it correctly), it to replace one menu (containing lots of submenus, separated by pipes) with several menus, (each containing only one submenu), separated by a pipe.

An alternative solution might be to do this with CSS and use something along the lines of:

#whatever li content:before " | "
#whatever li:first content:before "";

Rob Peters (makitso) wrote :

Colors and Clouds had this some releases ago. However, we moved it all to css like Greg says. However, :after and :before do not work in IE7 so some extra padding between li's is necessary.

I agree that CSS would better, but if so then I would drop the '|' completely and use a left border.

Changed in webtrees:
assignee: nobody → kiwi (kiwi3685)
status: New → Confirmed
importance: Undecided → Low
fisharebest (fisharebest) wrote :

Or simply let IE7 users get the display without the |
(or perhaps some other puncutation, such as • )

Fixed - svn 11914.

Changed in webtrees:
status: Confirmed → Fix Committed
lindon (ycm05) wrote :

Yes, CSS is definitely a better solution.

The last two changes in the patch were different validation errors however - see screenshot attached. Simply a space missing between parameters.
Regards,
lindon

Oops = I didn't look that far :-(

Fixed in svn 11918.

fisharebest (fisharebest) wrote :

Fix released in webtrees 1.2.2

Changed in webtrees:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers