Family Navigator generates invalid HTML

Bug #796268 reported by fisharebest on 2011-06-12
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
webtrees
Fix Released
Medium
Unassigned

Bug Description

The family navigator is generating duplicate CSS ID values.

There are multiple occurrences of: id="layout3" .

The stylesheets are expecting this, and have definitions for "#layout3" .

Should these be: class="layout3" ?

Similarly, there are repeated defintions for id="phusb", "pwife", "shusb", "swife", and "spouse". These are all formatted the same as "layout3". Do we need them?

Changed in webtrees:
assignee: nobody → kiwi (kiwi3685)
importance: Undecided → Medium

Greg

I just did a comprehensive search for "layout3" and can't find it anywhere in the system. Did you mean "flyout3"?

fisharebest (fisharebest) wrote :

Sorry - my typo. There are flyout1, flyout2, flyout3 and flyout4.

I've changed the ID flyout3 to class flyout3 throughout (svn 11801).

The rest need to be looked at carefully, but you are probably right. However, I'm tempted to do a more nmajor re-write, as this code is a complex collection of tables, divs, lists etc. I'm sure there must be an easy way :-)

It will take a while though, so I'll leave this bug open for now.

Changed in webtrees:
status: New → In Progress

IDs replaced with classes, and phusb", "pwife", "shusb", "swife", and "spouse" simplified to "flyout3" - svn 11932

I believe all these are now fixed, so I'll close this bug report. If any are missed, can someone please raise a fresh report quoting the specific issues concerned.

Fixed in svn 11954.

Changed in webtrees:
status: In Progress → Fix Committed
fisharebest (fisharebest) wrote :

Fix released in webtrees 1.2.2

Changed in webtrees:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers