Non-latin characters in surnames breaks sidebar indi/fam-list
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
webtrees |
Fix Committed
|
Low
|
fisharebest |
Bug Description
The individuals and families sidebar use the surname for several purposes.
As a CSS id:
<li id="sb_
This generates invalid HTML when surnames contain non-latin characters, puncuation marks, etc. We need a unique identifier containing valid characters. md5($surname) would be ideal, but JavaScript does not have an md5() function.
As an HTML attribute:
<a href="'.$surname.'" title="
This generates invalid HTML when the surname contains special characters. It needs to be escaped with htmlspecialchars(), but this will break the JavaScript - unless the JS implements an unhtmlentities() function.
To generate a URL:
url: "sidebar.
This generates invalid URLs when surnames contain special characters. The arguments need to be escaped with either JavaScript's escape() function or PHP's rawurlencode() function.
Changed in webtrees: | |
status: | New → Confirmed |
importance: | Undecided → Low |
Changed in webtrees: | |
status: | Confirmed → Triaged |
Changed in webtrees: | |
status: | Triaged → Fix Committed |
assignee: | nobody → fisharebest (fisharebest) |