Users management - find individual not working

Bug #758731 reported by Klemens Miehe
42
This bug affects 7 people
Affects Status Importance Assigned to Milestone
webtrees
Fix Released
Medium
Unassigned

Bug Description

the existing use permit, there is no possibility to look in the personal record of the user, add in new, it is possible to search by person (image). in V1.01. this was still possible.

Revision history for this message
Klemens Miehe (klemens-miehe) wrote :
Changed in webtrees:
status: New → Confirmed
wooc (wooc)
Changed in webtrees:
importance: Undecided → Low
Revision history for this message
Klemens Miehe (klemens-miehe) wrote :

I test it on the demo do not know if it is done.
changes in the possibility of searching for missing v1.1.2. see plant

Revision history for this message
kiwi (kiwi3685-deactivatedaccount) wrote :

It is not fixed. When it is the status will be "Fix committed"

Revision history for this message
kiwi (kiwi3685-deactivatedaccount) wrote :

Can someone who understands js better than me take a look at this:

http://php.scripts.psu.edu/rja171/widgets/autocomplete.php

It appears it might be a way to combine our autocomplete with inline editing, and perhasp solve this bug (ability to find individuals when setting user root ID etc).

Revision history for this message
meliza (meliza) wrote :

I can open the individual record in a new window from the Find list.

Revision history for this message
fisharebest (fisharebest) wrote :

Is this the same bug as #613235

Revision history for this message
wooc (wooc) wrote :

I think that this bug is about that there is not easy way to put individual XREF in user management.

See the attached image.

Revision history for this message
kiwi (kiwi3685-deactivatedaccount) wrote :

<<Is this the same bug as #613235>>

Not really. That bug actually only applied before we introduced inline editing on this field.

This bug is about not being able to use autocomplete, or any other direct assistance to find an indi to enter to these fields. You actually need to already know an indi xref, which we actually discourage everywhere else!!

Changed in webtrees:
status: Confirmed → Triaged
summary: - Users management.
+ Users management - find individual not working
wooc (wooc)
Changed in webtrees:
importance: Low → Medium
Revision history for this message
jon48 (genea-jaubart) wrote :

Hello,

I had a look at the bug above, and got something nearly working for the autocompletion. You can find attached a patch file.

I say "nearly" because an issue remains, and I am not sure why it is happening. Within the Admistration page context, the HTML response is displayed plainly, with the tags apparent. This is not happening if I insert the editable field in as standard test page. I do not know whether somebody has an idea about it.

The patch is just a hint. The added inline javascript could be factored in an external script file for instance.

Regards.

Revision history for this message
jon48 (genea-jaubart) wrote :

Stupid of me... I was missing the Jquery Autocomplete HTML extension...
I have added by calling the autocomplete.js script in the admin_user page.
Same comment as before, it might not have been done in the cleverest way, so feel free to refactor my additions.

Regards.

Jonathan

Revision history for this message
meliza (meliza) wrote :

Great patch.

Meliza

Revision history for this message
meliza (meliza) wrote :

I miss also the ability to see existing users' individual personal data by clicking on their user ID.

Meliza

Revision history for this message
jon48 (genea-jaubart) wrote :

Actually; hold on for this patch.
Looking at the remotely similar bug #613235, I realised that I have the same issue.

The autocomplete only works correctly in a single-gedcom context, not if you have several ones, and will look for individuals in the default GEDCOM, which may be not the one you want.

I am going to look further into it.

Jonathan

Revision history for this message
fisharebest (fisharebest) wrote :

The existing autocomplete.js tries to match every field in every form on every page that might need autocomplete.

I do not think this is the best strategy.

It may be better for each field that requires autocomplete to initialise itself in its own script.

This will make it easier to pass the extra parameter to choose a tree.

Revision history for this message
jon48 (genea-jaubart) wrote :

I am not sure what is the best strategy in general for the autocomplete.
I guess that the current JS approach has been an easy way to ensure that all fields identified as indis are correctly converted to autocomplete fields. It is falling indeed if you want to be a bit more complex in your actions (cf. bug #1018272, for which the solution I propose is a bit cumbersome...).
Each field could indeed own its own script & initialisation, but if so I would advocate for a generic flexible component (configured by its parameters) that would allow a consistent code .

Anyway, in my previous patch, the autocomplete.js is only used for its first lines (the HTML extension), not the part transforming the input fields. I then post another patch for this specific bug, which allows taking into account the associated gedcom.

Changed in webtrees:
status: Triaged → Fix Committed
Revision history for this message
fisharebest (fisharebest) wrote :

Fix released in 1.7.0

Changed in webtrees:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.