Source report by records shows wrong citation details

[meliza]

In the report for records I see often citation data of another source.

On my site when I create the Source report for source S326 - records, I see the citation of S357.

Meliza

[fisharebest (fisharebest)]

Is this the same as https://bugs.launchpad.net/webtrees/+bug/1382722

[fisharebest (fisharebest)]

> Is this the same as https://bugs.launchpad.net/webtrees/+bug/1382722

Reading the bug report again, it probably isn't.

[meliza (meliza)]

After some more testing, it seems to me that we see always the citation details of the individual record's 1st source, not of the reported source.

[fisharebest (fisharebest)]

On the demo site, run the source report for S1 and S2

Look at the entry for the birth of Queen Elizabeth. This event has two sources

The correct citation is shown for each report.

[meliza (meliza)]

Yes, fact sources s1 and s2 are OK.

I speak of record sources.
I filled 2 test record sources on the demo site to i1.
Please approve them and let's make sure we see the citations as expected.

Meliza

[meliza (meliza)]

I realized that I could approve the changes.

After that, when I run the report on the demo-dev site for source s1 and select source type record, I see the data as expected.
When I run it for s2 - source type record, I see the s1 data, not the s2 data.

Please tell me when to remove these record sources from the demo-dev site.

Meliza

[fisharebest (fisharebest)]

> Please tell me when to remove these record sources from the demo-dev site.

The demo sites are reset automatically every night at approx 04:00 UTC

[fisharebest (fisharebest)]

In function gedcomValueStartHandler(), we do not know if we are the 1st/2nd/3rd... repetition in the loop.

If we did know this number, the function get_gedcom_value() does not have a way to fetch it.

This may be a lot of work to fix.

[meliza (meliza)]

Perhaps we should not show the source citation details in the record sources report till we correct the issue.