Too easy to block yourself in site access rules

[Wes Groleau]

I had an unwelcome visitor, but it was not recorded in the "assumed search engine" list.

Thus there was no way to click on "deny" to create a rule.

So, I clicked deny on another address, intending to edit that rule.

It started with 5. so when I edited the TO address, I created a rule that denied a huge IP range--one that included my own! This made it impossible to edit the FROM address and fix the problem.

I recommend two changes:

1. before saving an edit to site access rules, check to see whether that would block the admin doing the edit. If so, instead of updating, pop-up an alert like
     "Blocking <user agent> from <IP> to <IP> would terminate your access, because you are using <user agent> at <IP>"

2. At the top of the page provide a New Rule form, with fields From, To, Agent, Comment, radio buttons for Allow/Deny/Bot, and buttons for Add or Clear.

[fisharebest (fisharebest)]

It is also too easy to delete the rule that currently allows you access

[fisharebest (fisharebest)]

Instead of preventing you from adding/deleting rules that would cause you to be locked out, we could disable the checks for the login/admin pages, as suggested by Frank - https://bugs.launchpad.net/webtrees/+bug/1250707

[fisharebest (fisharebest)]

We now check for blocking rules before allowing them to be saved

[fisharebest (fisharebest)]

Fix released in 1.7.0