Address bar doesn't support new TLDs

Bug #1441281 reported by Riccardo Padovani
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
webbrowser-app
Fix Released
Medium
Riccardo Padovani
webbrowser-app (Ubuntu)
Vivid
New
Undecided
Unassigned

Bug Description

We have a function in `src/app/webbrowser/AddressBar.qml` called `looksLikeAUrl()` that checks if an url is valid.

http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/src/app/webbrowser/AddressBar.qml#L238

It works well, but it checks tld length is <5.

TLD could be longer[0], so we should remove that restriction and find a better strategy to verify tld.

[0]: https://en.wikipedia.org/wiki/List_of_Internet_top-level_domains#ICANN-era_generic_top-level_domains

Related branches

Olivier Tilloy (osomon)
Changed in webbrowser-app:
status: New → Confirmed
importance: Undecided → Medium
description: updated
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

The best URL validator I had found is available at:
https://gist.github.com/dperini/729294
There is no size limit for TLD.

Changed in webbrowser-app:
status: Confirmed → In Progress
assignee: nobody → Riccardo Padovani (rpadovani)
Olivier Tilloy (osomon)
summary: - Update looksLikeAUrl() function
+ Address bar doesn't support new TLDs
Olivier Tilloy (osomon)
Changed in webbrowser-app:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.