Inconsistent swipe delete style
Bug #1358680 reported by
Nekhelesh Ramananthan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu UI Toolkit |
Triaged
|
Low
|
Zsombor Egri | ||
| webbrowser-app |
Fix Released
|
Medium
|
Riccardo Padovani | ||
| ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Low
|
Zsombor Egri | ||
Bug Description
The swipe delete style shown is inconsistent with other default apps like Dialer, Address Book and Clock. The new style used by the dialer, address book app etc..is not provided by the SDK. It is a custom component created by Renato. For consistency the web browser app should also use this style.
Related branches
lp:~rpadovani/webbrowser-app/1351167
- Olivier Tilloy: Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 1428 lines (+1007/-149)12 files modifiedpo/webbrowser-app.pot (+20/-30)
src/app/webbrowser/BookmarksList.qml (+1/-1)
src/app/webbrowser/CMakeLists.txt (+4/-0)
src/app/webbrowser/ExpandedHistoryView.qml (+88/-15)
src/app/webbrowser/HistorySectionDelegate.qml (+1/-2)
src/app/webbrowser/HistoryView.qml (+203/-47)
src/app/webbrowser/UrlDelegate.qml (+43/-54)
src/app/webbrowser/upstreamcomponents/ListItemWithActions.qml (+372/-0)
src/app/webbrowser/upstreamcomponents/ListItemWithActionsCheckBox.qml (+25/-0)
src/app/webbrowser/upstreamcomponents/MultipleSelectionListView.qml (+199/-0)
src/app/webbrowser/upstreamcomponents/MultipleSelectionVisualModel.qml (+31/-0)
src/app/webbrowser/upstreamcomponents/README (+20/-0)
Revision history for this message
| Nekhelesh Ramananthan (nik90) wrote | #1 |
Revision history for this message
| Nekhelesh Ramananthan (nik90) wrote | #2 |
Revision history for this message
| Olivier Tilloy (osomon) wrote | #3 |
Revision history for this message
| Nekhelesh Ramananthan (nik90) wrote | #4 |
Revision history for this message
| Zsombor Egri (zsombi) wrote | #5 |
| Changed in ubuntu-ui-toolkit: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| assignee: | nobody → Zsombor Egri (zsombi) |
| tags: | added: listitem |
| Changed in webbrowser-app: | |
| status: | New → In Progress |
| assignee: | nobody → Riccardo Padovani (rpadovani) |
| Changed in webbrowser-app: | |
| importance: | Undecided → Medium |
| Changed in webbrowser-app: | |
| status: | In Progress → Fix Released |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| assignee: | nobody → Zsombor Egri (zsombi) |
| importance: | Undecided → Low |
| status: | New → Triaged |
Revision history for this message
| Zsombor Egri (zsombi) wrote | #6 |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
I would argue that the new style needs to be merged back in the UITK, to benefit all apps.