Suggestions improvements
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Ubuntu UX |
High
|
James Mulholland | ||
| | webbrowser-app |
Fix Released
|
Medium
|
Ugo Riboni | |
| | webbrowser-app (Ubuntu) |
Undecided
|
Unassigned | ||
Bug Description
Per design specification, the suggestions that show up when the user types in the address bar need to be updated in the following ways:
- take up the whole screen (as opposed to being a popover)
- include additional sources: bookmarks (auto-suggest is being tracked separately by bug #1351151)
- display symbolic icons to tell apart different types of entries (search, history, bookmarks)
Related branches
- Olivier Tilloy: Approve on 2015-04-17
- PS Jenkins bot: Approve (continuous-integration) on 2015-04-16
-
Diff: 1185 lines (+555/-335)14 files modifiedsrc/app/webbrowser/Browser.qml (+29/-5)
src/app/webbrowser/CMakeLists.txt (+1/-1)
src/app/webbrowser/Suggestion.qml (+81/-0)
src/app/webbrowser/Suggestions.qml (+57/-85)
src/app/webbrowser/history-matches-model.cpp (+0/-92)
src/app/webbrowser/history-matches-model.h (+0/-62)
src/app/webbrowser/suggestions-filter-model.cpp (+135/-0)
src/app/webbrowser/suggestions-filter-model.h (+72/-0)
src/app/webbrowser/webbrowser-app.cpp (+2/-2)
tests/autopilot/webbrowser_app/emulators/browser.py (+3/-5)
tests/autopilot/webbrowser_app/tests/test_suggestions.py (+93/-28)
tests/unittests/CMakeLists.txt (+1/-1)
tests/unittests/suggestions-filter-model/CMakeLists.txt (+2/-2)
tests/unittests/suggestions-filter-model/tst_SuggestionsFilterModelTests.cpp (+79/-52)
| Changed in ubuntu-ux: | |
| importance: | Undecided → High |
| status: | New → Fix Committed |
| assignee: | nobody → Giorgio Venturi (giorgio-venturi) |
| Changed in webbrowser-app: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Ugo Riboni (uriboni) |
| Omer Akram (om26er) wrote : | #1 |
| Omer Akram (om26er) wrote : | #2 |
here is screenshot before installing the silo
| Omer Akram (om26er) wrote : | #3 |
after. No difference.
| Omer Akram (om26er) wrote : | #4 |
The popup does not take up the whole screen width as its meant to.
| Olivier Tilloy (osomon) wrote : | #5 |
The linked branch does not fix the popup style (this will be taken care of in a subsequent branch). What it does is include bookmarks in the suggestions, so if you have bookmarks that match the terms entered in the address bar, they will be displayed there too.
| Olivier Tilloy (osomon) wrote : | #6 |
Filed bug #1448212 to track the visual design update. Now closing this bug as fixed.
| Changed in webbrowser-app: | |
| status: | In Progress → Fix Released |
| Changed in webbrowser-app (Ubuntu): | |
| status: | New → Fix Released |
| Changed in ubuntu-ux: | |
| assignee: | Giorgio Venturi (giorgio-venturi) → James Mulholland (jamesjosephmulholland) |
| Changed in ubuntu-ux: | |
| status: | Fix Committed → Fix Released |
While testing the silo I am having hard time understanding what this bug really fixes. I have looked at the design doc as well but was not able to find what I was looking for.