Suggestions improvements
Bug #1351177 reported by
Olivier Tilloy
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu UX |
Fix Released
|
High
|
James Mulholland | ||
| webbrowser-app |
Fix Released
|
Medium
|
Ugo Riboni | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Per design specification, the suggestions that show up when the user types in the address bar need to be updated in the following ways:
- take up the whole screen (as opposed to being a popover)
- include additional sources: bookmarks (auto-suggest is being tracked separately by bug #1351151)
- display symbolic icons to tell apart different types of entries (search, history, bookmarks)
Related branches
lp:~uriboni/webbrowser-app/bookmarks-in-suggestions
- Olivier Tilloy: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 1185 lines (+555/-335)14 files modifiedsrc/app/webbrowser/Browser.qml (+29/-5)
src/app/webbrowser/CMakeLists.txt (+1/-1)
src/app/webbrowser/Suggestion.qml (+81/-0)
src/app/webbrowser/Suggestions.qml (+57/-85)
src/app/webbrowser/history-matches-model.cpp (+0/-92)
src/app/webbrowser/history-matches-model.h (+0/-62)
src/app/webbrowser/suggestions-filter-model.cpp (+135/-0)
src/app/webbrowser/suggestions-filter-model.h (+72/-0)
src/app/webbrowser/webbrowser-app.cpp (+2/-2)
tests/autopilot/webbrowser_app/emulators/browser.py (+3/-5)
tests/autopilot/webbrowser_app/tests/test_suggestions.py (+93/-28)
tests/unittests/CMakeLists.txt (+1/-1)
tests/unittests/suggestions-filter-model/CMakeLists.txt (+2/-2)
tests/unittests/suggestions-filter-model/tst_SuggestionsFilterModelTests.cpp (+79/-52)
| Changed in ubuntu-ux: | |
| importance: | Undecided → High |
| status: | New → Fix Committed |
| assignee: | nobody → Giorgio Venturi (giorgio-venturi) |
| Changed in webbrowser-app: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Ugo Riboni (uriboni) |
Revision history for this message
| Omer Akram (om26er) wrote | #1 |
Revision history for this message
| Omer Akram (om26er) wrote | #2 |
Revision history for this message
| Omer Akram (om26er) wrote | #3 |
Revision history for this message
| Omer Akram (om26er) wrote | #4 |
Revision history for this message
| Olivier Tilloy (osomon) wrote | #5 |
Revision history for this message
| Olivier Tilloy (osomon) wrote | #6 |
| Changed in webbrowser-app: | |
| status: | In Progress → Fix Released |
| Changed in webbrowser-app (Ubuntu): | |
| status: | New → Fix Released |
| Changed in ubuntu-ux: | |
| assignee: | Giorgio Venturi (giorgio-venturi) → James Mulholland (jamesjosephmulholland) |
| Changed in ubuntu-ux: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
While testing the silo I am having hard time understanding what this bug really fixes. I have looked at the design doc as well but was not able to find what I was looking for.