Downloading an image attachment in gmail silently fails

Bug #1329060 reported by Bill Filler
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-download-manager
Fix Released
High
Manuel de la Peña
webbrowser-app
Fix Released
High
Michael Sheldon

Bug Description

open a message in gmail webapp or browser that has a picture attached.
The page displays a preview image and a link with the file name

Expected result:
long pressing on image should display context popup menu to allow you to save image
long pressing on the link should display popup menu for actions that can be taken on a link

Actual result:
no popup menu displayed in either case

NOTE: these bugs are in addition to being able to actually download attachments which is being tracked https://bugs.launchpad.net/ubuntu/+source/unity-webapps-gmail/+bug/1309657

Tags: rtm14

Related branches

Bill Filler (bfiller)
Changed in webbrowser-app:
assignee: nobody → Michael Sheldon (michael-sheldon)
importance: Undecided → High
tags: added: rtm14
Revision history for this message
Olivier Tilloy (osomon) wrote :

I’m not seeing the same thing here: the context menus are being displayed both for the image thumbnail and for the link.

However when I try to save the image, it seems to work (I pick the gallery app, and I get a "download complete" notification) but the image isn’t actually saved. Something similar happens with the link, when I try to open it in a new tab, a new tab opens, but it remains blank.

I suspect that the code that extracts the image/link URLs is being fooled by gmail, I’ll need to look into it in more details.

Note that this can be reproduced on desktop too, by ensuring that getFormFactor() in plugin.cpp returns MOBILE.

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

As far as I can see there are two separate bugs here:

1) Webapps don't appear to display long press context menus at all (but the browser does)

2) Images can't be downloaded from GMail.

For issue 2, we are actually downloading the file, however because we're not sharing authentication cookies with UDM we end up downloading a HTML login page instead of the image. From a quick glance at the UDM code it looks like there might be some support for setting custom headers in the C++ API, but I don't see this exposed anywhere in the QML API at the moment, so we'll probably need to extend that first.

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

And possibly a third bug, if link URLs aren't opening correctly. But we do definitely get a file (albeit not the one we want) when downloading.

Revision history for this message
Olivier Tilloy (osomon) wrote :

The context menu not being displayed in the webapp container on long press is bug #1323735.

summary: - context menu not displayed for attachments in gmail
+ Downloading an image attachment in gmail silently fails
Changed in webbrowser-app:
status: New → Confirmed
Bill Filler (bfiller)
Changed in webbrowser-app:
milestone: none → feature-freeze
Changed in ubuntu-download-manager:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Manuel de la Peña (mandel)
Bill Filler (bfiller)
Changed in webbrowser-app:
status: Confirmed → In Progress
Bill Filler (bfiller)
Changed in webbrowser-app:
status: In Progress → Fix Released
Changed in ubuntu-download-manager:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.