[oxide] enable kinetic scrolling

Bug #1286195 reported by Bill Filler
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Oxide
Fix Released
Medium
Olivier Tilloy
webbrowser-app
Fix Released
High
Unassigned

Bug Description

we should enable kinetic scrolling like qtwebkit has so you can flick to scroll.

Tags: oxide

Related branches

Bill Filler (bfiller)
tags: added: oxide
Changed in webbrowser-app:
importance: Undecided → High
Olivier Tilloy (osomon)
Changed in oxide:
status: New → Confirmed
Changed in webbrowser-app:
status: New → Confirmed
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

I've not tested this, but it *should* just be a matter of setting RendererPreferences::touchscreen_fling_profile to something appropriate

Changed in oxide:
importance: Undecided → Medium
status: Confirmed → Triaged
Revision history for this message
Olivier Tilloy (osomon) wrote :

RendererPreferences::touchscreen_fling_profile is already initialized to a default value that, supposedly, generates a good default fling deceleration curve (see https://code.google.com/p/chromium/codesearch#chromium/src/content/public/common/renderer_preferences.cc).

I’ve tried playing with those values, but that doesn’t seem to make any difference, so I must be missing something to actually enable flick gestures. I’ve added kEnableSmoothScrolling to the command line switches, but that doesn’t make any difference either.

Olivier Tilloy (osomon)
Changed in oxide:
assignee: nobody → Olivier Tilloy (osomon)
status: Triaged → In Progress
Revision history for this message
Olivier Tilloy (osomon) wrote :

Ok, I finally nailed where the issue lies: the timestamp of the touch event we get from Qt cannot be used as a base::TimeDelta (they probably have different time origins). As a consequence, the time variable in TouchFlingGestureCurve::apply(…) was always computing to a negative value, thus cancelling the fling.

Olivier Tilloy (osomon)
Changed in oxide:
status: In Progress → Fix Committed
Changed in oxide:
status: Fix Committed → Fix Released
Olivier Tilloy (osomon)
Changed in webbrowser-app:
status: Confirmed → Fix Committed
Olivier Tilloy (osomon)
Changed in webbrowser-app:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.